Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: talk/app/webrtc/statscollector.cc

Issue 1416673006: Convert internal representation of Srtp cryptos from string to int. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Add back an old function name to prevent build break in chromium. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/app/webrtc/statscollector.cc
diff --git a/talk/app/webrtc/statscollector.cc b/talk/app/webrtc/statscollector.cc
index 347a84640cf9973a72d86e5133d5b4bc038dbb72..ee44b6edc71da67f563fd698f3058c1cd3445931 100644
--- a/talk/app/webrtc/statscollector.cc
+++ b/talk/app/webrtc/statscollector.cc
@@ -730,17 +730,17 @@ void StatsCollector::ExtractSessionInfo() {
channel_report->AddId(StatsReport::kStatsValueNameRemoteCertificateId,
remote_cert_report_id);
}
- const std::string& srtp_cipher = channel_iter.srtp_cipher;
- if (!srtp_cipher.empty()) {
+ int srtp_cipher = channel_iter.srtp_cipher;
pthatcher1 2015/11/11 19:59:40 Should we rename srtp_chiper to srtp_crypto_suite?
guoweis_webrtc 2015/11/17 01:21:15 Done.
+ if (srtp_cipher && rtc::SrtpCryptoSuiteToName(srtp_cipher).length()) {
channel_report->AddString(StatsReport::kStatsValueNameSrtpCipher,
- srtp_cipher);
+ rtc::SrtpCryptoSuiteToName(srtp_cipher));
}
int ssl_cipher = channel_iter.ssl_cipher;
pthatcher1 2015/11/11 19:59:40 And should we rename ssl_cipher to ssl_cipher_suit
guoweis_webrtc 2015/11/17 01:21:15 Done.
if (ssl_cipher &&
- rtc::SSLStreamAdapter::GetSslCipherSuiteName(ssl_cipher).length()) {
+ rtc::SSLStreamAdapter::SslCipherSuiteToName(ssl_cipher).length()) {
channel_report->AddString(
StatsReport::kStatsValueNameDtlsCipher,
- rtc::SSLStreamAdapter::GetSslCipherSuiteName(ssl_cipher));
+ rtc::SSLStreamAdapter::SslCipherSuiteToName(ssl_cipher));
}
int connection_id = 0;

Powered by Google App Engine
This is Rietveld 408576698