Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Side by Side Diff: webrtc/modules/audio_coding/main/acm2/audio_coding_module_unittest_oldapi.cc

Issue 1416633011: CodecManager::RegisterEncoder: Call SetFec on new encoder, not old (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@rac3
Patch Set: better better test Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/modules/audio_coding/main/acm2/codec_manager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 1629 matching lines...) Expand 10 before | Expand all | Expand 10 after
1640 EXPECT_CALL(mock_encoder, Max10MsFramesInAPacket()) 1640 EXPECT_CALL(mock_encoder, Max10MsFramesInAPacket())
1641 .Times(AtLeast(1)) 1641 .Times(AtLeast(1))
1642 .WillRepeatedly( 1642 .WillRepeatedly(
1643 Invoke(&encoder, &AudioEncoderPcmU::Max10MsFramesInAPacket)); 1643 Invoke(&encoder, &AudioEncoderPcmU::Max10MsFramesInAPacket));
1644 EXPECT_CALL(mock_encoder, GetTargetBitrate()) 1644 EXPECT_CALL(mock_encoder, GetTargetBitrate())
1645 .Times(AtLeast(1)) 1645 .Times(AtLeast(1))
1646 .WillRepeatedly(Invoke(&encoder, &AudioEncoderPcmU::GetTargetBitrate)); 1646 .WillRepeatedly(Invoke(&encoder, &AudioEncoderPcmU::GetTargetBitrate));
1647 EXPECT_CALL(mock_encoder, EncodeInternal(_, _, _, _)) 1647 EXPECT_CALL(mock_encoder, EncodeInternal(_, _, _, _))
1648 .Times(AtLeast(1)) 1648 .Times(AtLeast(1))
1649 .WillRepeatedly(Invoke(&encoder, &AudioEncoderPcmU::EncodeInternal)); 1649 .WillRepeatedly(Invoke(&encoder, &AudioEncoderPcmU::EncodeInternal));
1650 EXPECT_CALL(mock_encoder, SetFec(_))
1651 .Times(AtLeast(1))
1652 .WillRepeatedly(Invoke(&encoder, &AudioEncoderPcmU::SetFec));
1650 ASSERT_NO_FATAL_FAILURE( 1653 ASSERT_NO_FATAL_FAILURE(
1651 SetUpTestExternalEncoder(&mock_encoder, codec_inst.pltype)); 1654 SetUpTestExternalEncoder(&mock_encoder, codec_inst.pltype));
1652 Run("81a9d4c0bb72e9becc43aef124c981e9", "8f9b8750bd80fe26b6cbf6659b89f0f9", 1655 Run("81a9d4c0bb72e9becc43aef124c981e9", "8f9b8750bd80fe26b6cbf6659b89f0f9",
1653 50, test::AcmReceiveTestOldApi::kMonoOutput); 1656 50, test::AcmReceiveTestOldApi::kMonoOutput);
1654 } 1657 }
1655 1658
1656 // This test fixture is implemented to run ACM and change the desired output 1659 // This test fixture is implemented to run ACM and change the desired output
1657 // frequency during the call. The input packets are simply PCM16b-wb encoded 1660 // frequency during the call. The input packets are simply PCM16b-wb encoded
1658 // payloads with a constant value of |kSampleValue|. The test fixture itself 1661 // payloads with a constant value of |kSampleValue|. The test fixture itself
1659 // acts as PacketSource in between the receive test class and the constant- 1662 // acts as PacketSource in between the receive test class and the constant-
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
1763 Run(16000, 8000, 1000); 1766 Run(16000, 8000, 1000);
1764 } 1767 }
1765 1768
1766 TEST_F(AcmSwitchingOutputFrequencyOldApi, Toggle8KhzTo16Khz) { 1769 TEST_F(AcmSwitchingOutputFrequencyOldApi, Toggle8KhzTo16Khz) {
1767 Run(8000, 16000, 1000); 1770 Run(8000, 16000, 1000);
1768 } 1771 }
1769 1772
1770 #endif 1773 #endif
1771 1774
1772 } // namespace webrtc 1775 } // namespace webrtc
OLDNEW
« no previous file with comments | « no previous file | webrtc/modules/audio_coding/main/acm2/codec_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698