Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 1416373004: Move logging CriticalSection into implementation. (Closed)

Created:
5 years, 2 months ago by pbos-webrtc
Modified:
5 years, 2 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move logging CriticalSection into implementation. Prevents including platform headers from all files that include logging. Also removes warn_slow_logs_delay_ which adds contention to the logging critical section. BUG= R=tommi@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/225789d0670caf4742ba22b3a941df28d046ee4c

Patch Set 1 #

Total comments: 2

Patch Set 2 : g_log_crit + another C++11 loop #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -44 lines) Patch
M webrtc/base/logging.h View 4 chunks +3 lines, -11 lines 0 comments Download
M webrtc/base/logging.cc View 1 6 chunks +26 lines, -33 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
pbos-webrtc
TPAL woo
5 years, 2 months ago (2015-10-23 12:08:00 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416373004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416373004/1
5 years, 2 months ago (2015-10-23 12:08:48 UTC) #3
tommi
lgtm % nits https://codereview.webrtc.org/1416373004/diff/1/webrtc/base/logging.cc File webrtc/base/logging.cc (right): https://codereview.webrtc.org/1416373004/diff/1/webrtc/base/logging.cc#newcode104 webrtc/base/logging.cc:104: // Global lock for log subsystem, ...
5 years, 2 months ago (2015-10-23 12:53:31 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-23 13:01:03 UTC) #6
pbos-webrtc
g_log_crit + another C++11 loop
5 years, 2 months ago (2015-10-23 13:18:32 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/225789d0670caf4742ba22b3a941df28d046ee4c Cr-Commit-Position: refs/heads/master@{#10388}
5 years, 2 months ago (2015-10-23 13:21:19 UTC) #8
pbos-webrtc
5 years, 2 months ago (2015-10-23 13:21:21 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
225789d0670caf4742ba22b3a941df28d046ee4c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698