Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 1416213004: EGL10.eglCreateWindowSurface(): Replace Surface input with SurfaceHolder (Closed)

Created:
5 years, 2 months ago by magjed_webrtc
Modified:
5 years, 2 months ago
Reviewers:
perkj_webrtc
CC:
onedays77_gmail.com, webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

EGL10.eglCreateWindowSurface(): Replace Surface input with SurfaceHolder Sending a Surface as input to EGL10.eglCreateWindowSurface() is not supported everywhere. See this code as reference: https://android.googlesource.com/platform/frameworks/native.git/+/ae9610220b5f509687b840532f95f3638ee0146b/opengl/tools/glgen/stubs/egl/eglCreateWindowSurface.java#42 Sending a SurfaceHolder as input instead should hopefully be supported everywhere, and this is also what GlSurfaceView does: http://grepcode.com/file/repository.grepcode.com/java/ext/com.google.android/android/5.1.1_r1/android/opengl/GLSurfaceView.java#1076 Committed: https://crrev.com/c3402fc3ef0dfebdc82f71ca0bc9a8b549539a2b Cr-Commit-Position: refs/heads/master@{#10392}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M talk/app/webrtc/java/android/org/webrtc/EglBase.java View 4 chunks +9 lines, -9 lines 0 comments Download
M talk/app/webrtc/java/android/org/webrtc/SurfaceViewRenderer.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
magjed_webrtc
perkj - Please take a look.
5 years, 2 months ago (2015-10-23 22:45:38 UTC) #3
perkj_webrtc
On 2015/10/23 22:45:38, magjed_webrtc wrote: > perkj - Please take a look. lgtm
5 years, 2 months ago (2015-10-24 00:28:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416213004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416213004/1
5 years, 2 months ago (2015-10-24 00:29:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-24 01:13:18 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-24 01:13:29 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c3402fc3ef0dfebdc82f71ca0bc9a8b549539a2b
Cr-Commit-Position: refs/heads/master@{#10392}

Powered by Google App Engine
This is Rietveld 408576698