Added StopAecDump function to PeerConnectionFactory.

Added StopAecDump function to PeerConnectionFactory.

The function to stop recording an AEC dump was missing from the PeerConnectionFactory interface (only a start function was provided). This CL adds the missing stop function.

BUG=webrtc:4741
Committed: https://crrev.com/797ef123249f793655640e8cb6ff1eb4fe7e3223
Cr-Commit-Position: refs/heads/master@{#10372}

[ivoc, 2015-10-20 13:59:00]

Description was changed from

==========
Added StopAecDump function to PeerConnectionFactory.

BUG=webrtc:4741
==========

to

==========
Added StopAecDump function to PeerConnectionFactory.

BUG=webrtc:4741
==========

[ivoc, 2015-10-20 13:59:00]

ivoc@webrtc.org changed reviewers:
+ pthatcher@webrtc.org, solenberg@webrtc.org

[ivoc, 2015-10-20 14:00:14]

Description was changed from

==========
Added StopAecDump function to PeerConnectionFactory.

BUG=webrtc:4741
==========

to

==========
Added StopAecDump function to PeerConnectionFactory.

The function to stop recording an AEC dump was missing from the
PeerConnectionFactory interface (only a start function was provided). This CL
adds the missing stop function.

BUG=webrtc:4741
==========

[ivoc, 2015-10-20 15:24:41]

Hi guys,

Please have a look at this small CL to add a missing function to stop recording
AEC dumps to the PeerConnectionFactoryInterface. Currently the AEC dump
functionality is only used in Chrome, where the start/stop functions are called
directly on the interface of the Audio Processing Module. For other applications
that is not really convenient, so it makes sense to add a stop function here
(especially since the start function is available).

[the sun, 2015-10-21 10:31:48]

lgtm

https://codereview.webrtc.org/1415733005/diff/1/talk/media/base/mediaengine.h
File talk/media/base/mediaengine.h (right):

https://codereview.webrtc.org/1415733005/diff/1/talk/media/base/mediaengine.h...
talk/media/base/mediaengine.h:125: // Starts recording AEC dump.
Starts->Stops

[pthatcher1, 2015-10-22 06:24:25]

lgtm

[ivoc, 2015-10-22 07:47:00]

The CQ bit was checked by ivoc@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-22 07:47:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1415733005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1415733005/20001

[commit-bot: I haz the power, 2015-10-22 07:48:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-22 07:48:12]

Dry run: Try jobs failed on following builders:
  android_clang_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_clang_dbg/build...)
  android_gn_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_gn_dbg/builds/6376)
  android_gn_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_gn_rel/builds/6423)
  ios_arm64_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/5074)
  ios_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/8827)
  mac_compile_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/611)
  mac_compile_x64_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_x64_dbg/bui...)
  mac_x64_gn_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_x64_gn_dbg/builds/4742)

[ivoc, 2015-10-22 08:14:09]

The CQ bit was checked by ivoc@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-22 08:14:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1415733005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1415733005/40001

[commit-bot: I haz the power, 2015-10-22 10:23:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-22 10:23:30]

Dry run: This issue passed the CQ dry run.

[ivoc, 2015-10-22 10:24:22]

The CQ bit was checked by ivoc@webrtc.org

[ivoc, 2015-10-22 10:24:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
solenberg@webrtc.org, pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1415733005/#ps40001 (title:
"Rebase.")

[commit-bot: I haz the power, 2015-10-22 10:24:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1415733005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1415733005/40001

[commit-bot: I haz the power, 2015-10-22 10:25:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-22 10:25:54]

Patchset 3 (id:??) landed as
https://crrev.com/797ef123249f793655640e8cb6ff1eb4fe7e3223
Cr-Commit-Position: refs/heads/master@{#10372}