Update isolate files for swarming tests

Update isolate files for swarming tests

Xvfb is needed for the screen capture tests in modules_unittests,
which also brings in xdisplaycheck used by testing/xvfb.py.

libjingle_media_unittest was missing a resource video in the .isolate
file.

BUG=chromium:497757
R=stip@chromium.org

Committed: https://crrev.com/9589e2af1642fce385fb8c47e3726a5c416a4e02
Cr-Commit-Position: refs/heads/master@{#10365}

[kjellander_webrtc, 2015-10-21 15:24:34]

Description was changed from

==========
Fixes for swarming tests.

Xvfb is needed for the screen capture tests in modules_unittests,
which also brings in xdisplaycheck used by testing/xvfb.py.

libjingle_media_unittest was missing a resource video in the .isolate
file.

BUG=chromium:497757
==========

to

==========
Fixes for swarming tests.

Xvfb is needed for the screen capture tests in modules_unittests,
which also brings in xdisplaycheck used by testing/xvfb.py.

libjingle_media_unittest was missing a resource video in the .isolate
file.

BUG=chromium:497757
==========

[kjellander_webrtc, 2015-10-21 15:24:34]

kjellander@webrtc.org changed reviewers:
+ stip@chromium.org

[ghost stip (do not use), 2015-10-21 15:29:18]

lgtm with a question about the command

https://codereview.webrtc.org/1415603005/diff/1/webrtc/modules/modules_unitte...
File webrtc/modules/modules_unittests.isolate (right):

https://codereview.webrtc.org/1415603005/diff/1/webrtc/modules/modules_unitte...
webrtc/modules/modules_unittests.isolate:149: '<(PRODUCT_DIR)',
do you need this line here?

[kjellander_webrtc, 2015-10-21 15:30:12]

https://codereview.webrtc.org/1415603005/diff/1/webrtc/modules/modules_unitte...
File webrtc/modules/modules_unittests.isolate (right):

https://codereview.webrtc.org/1415603005/diff/1/webrtc/modules/modules_unitte...
webrtc/modules/modules_unittests.isolate:149: '<(PRODUCT_DIR)',
On 2015/10/21 15:29:18, stip (sweden time) wrote:
> do you need this line here?

Yeah, it wants the build output dir as an argument. See
https://code.google.com/p/chromium/codesearch#search/&q=xvfb.py%20file:isolat...

[kjellander_webrtc, 2015-10-21 16:30:11]

I did a local test and it turns out the conditions are needed or we'll get
errors when running the test on Android.
I didn't run our android trybots to find this out since they're overloaded
currently.

https://codereview.webrtc.org/1415603005/diff/20001/webrtc/modules/modules_un...
File webrtc/modules/modules_unittests.isolate (right):

https://codereview.webrtc.org/1415603005/diff/20001/webrtc/modules/modules_un...
webrtc/modules/modules_unittests.isolate:145: ['(OS=="linux" or OS=="mac" or
OS=="win") and use_x11==1', {
Kind of ugly but needed since isolate doesn't support multiple levels of
condition statements, it seems.

[kjellander_webrtc, 2015-10-22 04:43:57]

Description was changed from

==========
Fixes for swarming tests.

Xvfb is needed for the screen capture tests in modules_unittests,
which also brings in xdisplaycheck used by testing/xvfb.py.

libjingle_media_unittest was missing a resource video in the .isolate
file.

BUG=chromium:497757
==========

to

==========
Update isolate files for swarming tests

Xvfb is needed for the screen capture tests in modules_unittests,
which also brings in xdisplaycheck used by testing/xvfb.py.

libjingle_media_unittest was missing a resource video in the .isolate
file.

BUG=chromium:497757
==========

[kjellander_webrtc, 2015-10-22 04:48:39]

Committed patchset #2 (id:20001) manually as
9589e2af1642fce385fb8c47e3726a5c416a4e02 (presubmit successful).

[commit-bot: I haz the power, 2015-10-22 04:48:47]

Patchset 2 (id:??) landed as
https://crrev.com/9589e2af1642fce385fb8c47e3726a5c416a4e02
Cr-Commit-Position: refs/heads/master@{#10365}