Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: talk/media/webrtc/webrtcvoiceengine.h

Issue 1415563003: Create AudioSendStreams in WVoE. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@wvoe_default_send_channel
Patch Set: rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/media/webrtc/webrtcvoiceengine.h
diff --git a/talk/media/webrtc/webrtcvoiceengine.h b/talk/media/webrtc/webrtcvoiceengine.h
index a8f3ec85115e388cf416d7cc24097e593673807e..a70840565b433c6188152eecd41719d416ee2cf2 100644
--- a/talk/media/webrtc/webrtcvoiceengine.h
+++ b/talk/media/webrtc/webrtcvoiceengine.h
@@ -172,6 +172,8 @@ class WebRtcVoiceEngine
Settable<bool> extended_filter_aec_;
Settable<bool> delay_agnostic_aec_;
Settable<bool> experimental_ns_;
+
+ RTC_DISALLOW_COPY_AND_ASSIGN(WebRtcVoiceEngine);
};
// WebRtcVoiceMediaChannel is an implementation of VoiceMediaChannel that uses
@@ -265,11 +267,6 @@ class WebRtcVoiceMediaChannel : public VoiceMediaChannel,
bool SetPlayout(int channel, bool playout);
static Error WebRtcErrorToChannelError(int err_code);
- class WebRtcVoiceChannelRenderer;
- // Map of ssrc to WebRtcVoiceChannelRenderer object. A new object of
- // WebRtcVoiceChannelRenderer will be created for every new stream and
- // will be destroyed when the stream goes away.
- typedef std::map<uint32_t, WebRtcVoiceChannelRenderer*> ChannelMap;
typedef int (webrtc::VoERTP_RTCP::* ExtensionSetterFunction)(int, bool,
unsigned char);
@@ -327,12 +324,12 @@ class WebRtcVoiceMediaChannel : public VoiceMediaChannel,
// send streams. See: https://code.google.com/p/webrtc/issues/detail?id=4740
uint32_t receiver_reports_ssrc_ = 1;
- // send_channels_ contains the channels which are being used for sending.
- // When the default channel (default_send_channel_id) is used for sending, it
- // is contained in send_channels_, otherwise not.
- ChannelMap send_channels_;
+ class WebRtcAudioSendStream;
+ std::map<uint32_t, WebRtcAudioSendStream*> send_streams_;
std::vector<RtpHeaderExtension> send_extensions_;
- ChannelMap receive_channels_;
+
+ class WebRtcAudioReceiveStream;
+ std::map<uint32_t, WebRtcAudioReceiveStream*> receive_channels_;
std::map<uint32_t, webrtc::AudioReceiveStream*> receive_streams_;
std::map<uint32_t, StreamParams> receive_stream_params_;
// receive_channels_ can be read from WebRtc callback thread. Access from
@@ -340,6 +337,8 @@ class WebRtcVoiceMediaChannel : public VoiceMediaChannel,
// Reads on the worker thread are ok.
std::vector<RtpHeaderExtension> receive_extensions_;
std::vector<webrtc::RtpExtension> recv_rtp_extensions_;
+
+ RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(WebRtcVoiceMediaChannel);
};
} // namespace cricket

Powered by Google App Engine
This is Rietveld 408576698