Create AudioSendStreams in WVoE.

- Introduce internal classes WebRtcAudio[Send|Receive]Stream in WebRtcVoiceMediaChannel.
- Remove WebRtcVoiceMediaChannel::WebRtcVoiceChannelRenderer
- Create webrtc::AudioSendStreams.

BUG=webrtc:4690
Committed: https://crrev.com/c96df779b0c9255f25dc78c20a4cd4dff1776384
Cr-Commit-Position: refs/heads/master@{#10361}

[the sun, 2015-10-20 09:48:04]

Description was changed from

==========
Create AudioSendStreams in WVoE.

BUG=webrtc:4690
==========

to

==========
- Introduce internal classes WebRtcAudio[Send|Receive]Stream in
WebRtcVoiceMediaChannel.
- Create webrtc::AudioSendStreams.

BUG=webrtc:4690
==========

[the sun, 2015-10-20 09:48:04]

solenberg@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[the sun, 2015-10-21 08:05:07]

Description was changed from

==========
- Introduce internal classes WebRtcAudio[Send|Receive]Stream in
WebRtcVoiceMediaChannel.
- Create webrtc::AudioSendStreams.

BUG=webrtc:4690
==========

to

==========
- Introduce internal classes WebRtcAudio[Send|Receive]Stream in
WebRtcVoiceMediaChannel.
- Remove WebRtcVoiceMediaChannel::WebRtcVoiceChannelRenderer
- Create webrtc::AudioSendStreams.

BUG=webrtc:4690
==========

[kwiberg-webrtc, 2015-10-21 14:04:40]

lgtm

https://codereview.webrtc.org/1415563003/diff/100001/talk/media/webrtc/fakewe...
File talk/media/webrtc/fakewebrtccall.h (right):

https://codereview.webrtc.org/1415563003/diff/100001/talk/media/webrtc/fakewe...
talk/media/webrtc/fakewebrtccall.h:41: class FakeAudioSendStream : public
webrtc::AudioSendStream {
Maybe it's just me not being familiar enough with the code, but a sentence on
what this class does would have been nice.

https://codereview.webrtc.org/1415563003/diff/100001/talk/media/webrtc/webrtc...
File talk/media/webrtc/webrtcvoiceengine.cc (right):

https://codereview.webrtc.org/1415563003/diff/100001/talk/media/webrtc/webrtc...
talk/media/webrtc/webrtcvoiceengine.cc:1335: stream_ = nullptr;
Setting these to null isn't necessary, is it?

https://codereview.webrtc.org/1415563003/diff/100001/talk/media/webrtc/webrtc...
talk/media/webrtc/webrtcvoiceengine.cc:1345: if (renderer_ != nullptr) {
Pointers are false iff they're null.

https://codereview.webrtc.org/1415563003/diff/100001/talk/media/webrtc/webrtc...
File talk/media/webrtc/webrtcvoiceengine_unittest.cc (right):

https://codereview.webrtc.org/1415563003/diff/100001/talk/media/webrtc/webrtc...
talk/media/webrtc/webrtcvoiceengine_unittest.cc:1885: uint32_t ssrc =
kSsrcs4[i];
for (uint32_t ssrc : kSsrcs4)

[the sun, 2015-10-21 14:42:24]

https://codereview.webrtc.org/1415563003/diff/100001/talk/media/webrtc/fakewe...
File talk/media/webrtc/fakewebrtccall.h (right):

https://codereview.webrtc.org/1415563003/diff/100001/talk/media/webrtc/fakewe...
talk/media/webrtc/fakewebrtccall.h:41: class FakeAudioSendStream : public
webrtc::AudioSendStream {
On 2015/10/21 14:04:40, kwiberg-webrtc wrote:
> Maybe it's just me not being familiar enough with the code, but a sentence on
> what this class does would have been nice.

Added comment at start of file.

https://codereview.webrtc.org/1415563003/diff/100001/talk/media/webrtc/webrtc...
File talk/media/webrtc/webrtcvoiceengine.cc (right):

https://codereview.webrtc.org/1415563003/diff/100001/talk/media/webrtc/webrtc...
talk/media/webrtc/webrtcvoiceengine.cc:1335: stream_ = nullptr;
On 2015/10/21 14:04:40, kwiberg-webrtc wrote:
> Setting these to null isn't necessary, is it?

No.

https://codereview.webrtc.org/1415563003/diff/100001/talk/media/webrtc/webrtc...
talk/media/webrtc/webrtcvoiceengine.cc:1345: if (renderer_ != nullptr) {
On 2015/10/21 14:04:40, kwiberg-webrtc wrote:
> Pointers are false iff they're null.

Done.

https://codereview.webrtc.org/1415563003/diff/100001/talk/media/webrtc/webrtc...
File talk/media/webrtc/webrtcvoiceengine_unittest.cc (right):

https://codereview.webrtc.org/1415563003/diff/100001/talk/media/webrtc/webrtc...
talk/media/webrtc/webrtcvoiceengine_unittest.cc:1885: uint32_t ssrc =
kSsrcs4[i];
On 2015/10/21 14:04:40, kwiberg-webrtc wrote:
> for (uint32_t ssrc : kSsrcs4)

Thanks!

[the sun, 2015-10-21 14:54:30]

The CQ bit was checked by solenberg@webrtc.org

[the sun, 2015-10-21 14:54:30]

The patchset sent to the CQ was uploaded after l-g-t-m from kwiberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1415563003/#ps140001 (title:
"rebase")

[commit-bot: I haz the power, 2015-10-21 14:54:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1415563003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1415563003/140001

[the sun, 2015-10-21 15:30:17]

The CQ bit was checked by solenberg@webrtc.org

[the sun, 2015-10-21 15:30:17]

The patchset sent to the CQ was uploaded after l-g-t-m from kwiberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1415563003/#ps160001 (title:
"one e")

[commit-bot: I haz the power, 2015-10-21 15:30:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1415563003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1415563003/160001

[the sun, 2015-10-21 17:25:59]

The CQ bit was unchecked by solenberg@webrtc.org

[the sun, 2015-10-21 17:26:00]

The CQ bit was checked by solenberg@webrtc.org

[commit-bot: I haz the power, 2015-10-21 17:26:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1415563003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1415563003/160001

[commit-bot: I haz the power, 2015-10-21 17:30:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-21 17:30:44]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[the sun, 2015-10-21 18:07:15]

The CQ bit was checked by solenberg@webrtc.org

[commit-bot: I haz the power, 2015-10-21 18:07:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1415563003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1415563003/160001

[commit-bot: I haz the power, 2015-10-21 20:01:58]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2015-10-21 20:02:05]

Patchset 9 (id:??) landed as
https://crrev.com/c96df779b0c9255f25dc78c20a4cd4dff1776384
Cr-Commit-Position: refs/heads/master@{#10361}