Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1415413004: Use webrtc/base/logging.h for video. (Closed)

Created:
5 years, 2 months ago by pbos-webrtc
Modified:
5 years, 1 month ago
Reviewers:
mflodman
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), henrika_webrtc, stefan-webrtc, tterriberry_mozilla.com, andresp, peah-webrtc, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use webrtc/base/logging.h for video. BUG=webrtc:5118 R=mflodman@webrtc.org Committed: https://crrev.com/415d2cd7454d93b3727fce9147090a24e4c3ccba Cr-Commit-Position: refs/heads/master@{#10403}

Patch Set 1 #

Patch Set 2 : redo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M webrtc/video/send_statistics_proxy.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/video_capture_input.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M webrtc/video/video_decoder.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/video_encoder.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/video_receive_stream.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/video_send_stream.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M webrtc/video_engine/overuse_frame_detector.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video_engine/stream_synchronization.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video_engine/vie_channel.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M webrtc/video_engine/vie_encoder.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M webrtc/video_engine/vie_receiver.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M webrtc/video_engine/vie_sync_module.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415413004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415413004/1
5 years, 2 months ago (2015-10-23 09:38:54 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_compile_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_compile_dbg/builds/664)
5 years, 2 months ago (2015-10-23 09:43:52 UTC) #4
pbos-webrtc
PTAL for video now
5 years, 2 months ago (2015-10-23 13:32:04 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415413004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415413004/20001
5 years, 2 months ago (2015-10-23 13:32:21 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-23 14:34:37 UTC) #11
mflodman
LGTM
5 years, 1 month ago (2015-10-26 10:25:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415413004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415413004/20001
5 years, 1 month ago (2015-10-26 10:25:28 UTC) #14
pbos-webrtc
Committed patchset #2 (id:20001) manually as 415d2cd7454d93b3727fce9147090a24e4c3ccba (presubmit successful).
5 years, 1 month ago (2015-10-26 10:35:33 UTC) #15
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 10:35:38 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/415d2cd7454d93b3727fce9147090a24e4c3ccba
Cr-Commit-Position: refs/heads/master@{#10403}

Powered by Google App Engine
This is Rietveld 408576698