webrtc/modules/audio_coding/codecs/opus/opus_inst.h - Issue 1415173005: Prevent Opus DTX from generating intermittent noise during silence

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/opus/opus_inst.h

Issue 1415173005: Prevent Opus DTX from generating intermittent noise during silence (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: a fix after rebase Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/modules/audio_coding/codecs/opus/opus_inst.h

diff --git a/webrtc/modules/audio_coding/codecs/opus/opus_inst.h b/webrtc/modules/audio_coding/codecs/opus/opus_inst.h

index 373db392a6f3acbfeca4bca22f481aed56bffd82..fa799b6cef0283eec14cbc2ce2edcbc047152568 100644

--- a/webrtc/modules/audio_coding/codecs/opus/opus_inst.h

+++ b/webrtc/modules/audio_coding/codecs/opus/opus_inst.h

@@ -15,7 +15,13 @@

struct WebRtcOpusEncInst {

OpusEncoder* encoder;

+ int channels;

int in_dtx_mode;

+ // When Opus is in DTX mode, we use |zero_counts| to count consecutive zeros

the sun 2015/11/09 12:41:00 Should you add a TODO to remove this workaround on

minyue-webrtc 2015/11/09 15:13:00 Done.

+ // to break long zero segment so as to prevent DTX from going wrong. We use

+ // one counter for each channel. After each encoding, |zero_counts| contain

+ // the remaining zeros from the last frame.

+ size_t* zero_counts;

};

struct WebRtcOpusDecInst {

« no previous file with comments | « no previous file | webrtc/modules/audio_coding/codecs/opus/opus_interface.c » ('j') | webrtc/modules/audio_coding/codecs/opus/opus_interface.c » ('J')