Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1415163002: Removing AudioCoding class, a.k.a the new ACM API (Closed)

Created:
5 years, 2 months ago by hlundin-webrtc
Modified:
5 years, 1 month ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, peah-webrtc, kwiberg-webrtc, tlegrand-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removing AudioCoding class, a.k.a the new ACM API We have decided not to do a switch from old (AudioCodingModule) to new (AudioCoding) API. Instead, we will gradually evolve the old API to meet the new design goals. As a consequence of this decision, the AudioCoding and AudioCodingImpl classes are deleted. Also removing associated unit test sources. No test coverage is lost with this operation, since the tests for the "old" API are testing more than the deleted tests did. BUG=webrtc:3520 Committed: https://crrev.com/e9eca8f5ae60116a2351634575faf4cd5e338e61 Cr-Commit-Position: refs/heads/master@{#10406}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2346 lines) Patch
D webrtc/modules/audio_coding/main/acm2/acm_receive_test.h View 1 chunk +0 lines, -64 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/acm_receive_test.cc View 1 chunk +0 lines, -136 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/acm_receiver_unittest.cc View 1 chunk +0 lines, -370 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/acm_send_test.h View 1 chunk +0 lines, -82 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/acm_send_test.cc View 1 chunk +0 lines, -143 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/audio_coding_module.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.h View 1 chunk +0 lines, -73 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc View 1 chunk +0 lines, -283 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/audio_coding_module_unittest.cc View 1 chunk +0 lines, -1004 lines 0 comments Download
M webrtc/modules/audio_coding/main/audio_coding_module.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/main/interface/audio_coding_module.h View 1 chunk +0 lines, -171 lines 0 comments Download
M webrtc/modules/modules.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
hlundin-webrtc
Karl, PTAL.
5 years, 2 months ago (2015-10-21 14:03:27 UTC) #2
kwiberg-webrtc
lgtm 💥
5 years, 1 month ago (2015-10-26 10:48:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415163002/1
5 years, 1 month ago (2015-10-26 10:50:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-26 12:26:43 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 12:26:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e9eca8f5ae60116a2351634575faf4cd5e338e61
Cr-Commit-Position: refs/heads/master@{#10406}

Powered by Google App Engine
This is Rietveld 408576698