Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1415013006: Changed timeout to 6s for reporting android camera freeze. (Closed)

Created:
5 years, 1 month ago by perkj_webrtc
Modified:
5 years, 1 month ago
Reviewers:
AlexG
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Changed timeout to 6s for reporting android camera freeze. Also distinguish between camera failures and failures due to that buffers has not been returned. Adds unit tests for making sure CameraEventHandler.onError is triggered if frames are not returned. BUG=b/25514149 Committed: https://crrev.com/3bfef44a4de22c562bdfd787872ef4a13aa1ad60 Cr-Commit-Position: refs/heads/master@{#10555}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -5 lines) Patch
M talk/app/webrtc/androidtests/src/org/webrtc/VideoCapturerAndroidTest.java View 1 chunk +12 lines, -0 lines 0 comments Download
M talk/app/webrtc/androidtests/src/org/webrtc/VideoCapturerAndroidTestFixtures.java View 3 chunks +36 lines, -1 line 0 comments Download
M talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java View 3 chunks +14 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
perkj_webrtc
Can you please review?
5 years, 1 month ago (2015-11-06 10:16:23 UTC) #2
AlexG
lgtm
5 years, 1 month ago (2015-11-06 17:47:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415013006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415013006/1
5 years, 1 month ago (2015-11-08 14:04:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-08 14:58:20 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-08 14:58:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3bfef44a4de22c562bdfd787872ef4a13aa1ad60
Cr-Commit-Position: refs/heads/master@{#10555}

Powered by Google App Engine
This is Rietveld 408576698