Implement AudioSendStream::GetStats().

talk/media/webrtc/fakewebrtccall.cc

 /*
  * libjingle
  * Copyright 2015 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  *  1. Redistributions of source code must retain the above copyright notice,
  *     this list of conditions and the following disclaimer.
  *  2. Redistributions in binary form must reproduce the above copyright notice,
@@ skipping 21 matching lines @@
 #include "talk/media/base/rtputils.h"
 #include "webrtc/base/checks.h"
 #include "webrtc/base/gunit.h"
 
 namespace cricket {
 FakeAudioSendStream::FakeAudioSendStream(
     const webrtc::AudioSendStream::Config& config) : config_(config) {
   RTC_DCHECK(config.voe_channel_id != -1);
 }
 
-webrtc::AudioSendStream::Stats FakeAudioSendStream::GetStats() const {
-  return webrtc::AudioSendStream::Stats();
+void FakeAudioSendStream::SetStats(
+    const webrtc::AudioSendStream::Stats& stats) {
+  stats_ = stats;

[tommi, 2015/10/23 12:50:37]

if you can have a thread checker here I think that would be a good thing even
though this is just a test class.

[the sun, 2015/10/23 15:14:16]

Hmm. Hmm. Hmm. No.

For that to have any good effects the threading assumptions must be kept in
tight sync with the real AudioSendStream. Such implicit assumptions are likely
to fall short.

This class is intended for injection in unit tests for
WebRtcVoiceEngine/WebRtcVoiceMediaChannel and should be as simple as ever
possible, else Gödel comes chasing us. Threading assumptions of the webrtc::Call
classes should be tested separately, and integration tests should verify that
the classes make the same assumptions.

 }
 
 const webrtc::AudioSendStream::Config&
     FakeAudioSendStream::GetConfig() const {
   return config_;
 }
 
+webrtc::AudioSendStream::Stats FakeAudioSendStream::GetStats() const {
+  return stats_;

[tommi, 2015/10/23 12:50:37]

i.e. same thread as this runs on and any other call that touches stats_

[the sun, 2015/10/23 15:14:16]

Know what you're saying, but see above comment.

+}
+
 FakeAudioReceiveStream::FakeAudioReceiveStream(
     const webrtc::AudioReceiveStream::Config& config)
     : config_(config), received_packets_(0) {
   RTC_DCHECK(config.voe_channel_id != -1);
 }
 
 const webrtc::AudioReceiveStream::Config&
     FakeAudioReceiveStream::GetConfig() const {
   return config_;
 }
 
 void FakeAudioReceiveStream::SetStats(
     const webrtc::AudioReceiveStream::Stats& stats) {
   stats_ = stats;
 }
 
 void FakeAudioReceiveStream::IncrementReceivedPackets() {
   received_packets_++;
 }
 
+webrtc::AudioReceiveStream::Stats FakeAudioReceiveStream::GetStats() const {
+  return stats_;
+}
+
 FakeVideoSendStream::FakeVideoSendStream(
     const webrtc::VideoSendStream::Config& config,
     const webrtc::VideoEncoderConfig& encoder_config)
     : sending_(false),
       config_(config),
       codec_settings_set_(false),
       num_swapped_frames_(0) {
   RTC_DCHECK(config.encoder_settings.encoder != NULL);
   ReconfigureVideoEncoder(encoder_config);
 }
@@ skipping 324 matching lines @@
 }
 
 void FakeCall::SignalNetworkState(webrtc::NetworkState state) {
   network_state_ = state;
 }
 
 void FakeCall::OnSentPacket(const rtc::SentPacket& sent_packet) {
   last_sent_packet_ = sent_packet;
 }
 }  // namespace cricket