talk/app/webrtc/androidvideocapturer.cc - Issue 1414703002: passing |buffer| by reference in AndroidVideoCapturer::OnIncomingFrame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/app/webrtc/androidvideocapturer.cc

Issue 1414703002: passing |buffer| by reference in AndroidVideoCapturer::OnIncomingFrame (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: fix for formatting Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « talk/app/webrtc/androidvideocapturer.h ('k') | talk/app/webrtc/java/jni/androidvideocapturer_jni.h » ('j') | talk/app/webrtc/java/jni/androidvideocapturer_jni.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: talk/app/webrtc/androidvideocapturer.cc

diff --git a/talk/app/webrtc/androidvideocapturer.cc b/talk/app/webrtc/androidvideocapturer.cc

index 2d5a1afea9f66b42781099ea4b4621d4df7fc10d..afcfb5bb7c79c314a3cb1fac36f386e72983e8fc 100644

--- a/talk/app/webrtc/androidvideocapturer.cc

+++ b/talk/app/webrtc/androidvideocapturer.cc

@@ -211,7 +211,7 @@ void AndroidVideoCapturer::OnCapturerStarted(bool success) {

}

void AndroidVideoCapturer::OnIncomingFrame(

- rtc::scoped_refptr<webrtc::VideoFrameBuffer> buffer,

+ const rtc::scoped_refptr<webrtc::VideoFrameBuffer>& buffer,

int rotation,

int64_t time_stamp) {

RTC_CHECK(thread_checker_.CalledOnValidThread());