passing |buffer| by reference in AndroidVideoCapturer::OnIncomingFrame

passing |buffer| by reference in AndroidVideoCapturer::OnIncomingFrame

BUG=webrtc:5062
Committed: https://crrev.com/30a5b5e9fb574016ced1a45ae43921c1a01860a0
Cr-Commit-Position: refs/heads/master@{#10342}

[olka_webrtc, 2015-10-20 08:43:10]

Patchset #1 (id:1) has been deleted

[olka_webrtc, 2015-10-20 08:43:24]

Patchset #1 (id:20001) has been deleted

[olka_webrtc, 2015-10-20 08:46:09]

olka@webrtc.org changed reviewers:
+ magjed@webrtc.org

[olka_webrtc, 2015-10-20 08:46:09]

Hi Magnus,
Could you please review the code?
Thanks!

[magjed_webrtc, 2015-10-20 13:06:23]

https://codereview.webrtc.org/1414703002/diff/40001/talk/app/webrtc/java/jni/...
File talk/app/webrtc/java/jni/androidvideocapturer_jni.h (right):

https://codereview.webrtc.org/1414703002/diff/40001/talk/app/webrtc/java/jni/...
talk/app/webrtc/java/jni/androidvideocapturer_jni.h:75: template <typename T>
struct Identity  { typedef T type;  };
It this necessary to make it compile now?
nit: Remove extra space after 'typedef T type'. You can also use 'git cl format'
to fix stuff like that automatically.

[olka_webrtc, 2015-10-20 14:40:22]

Yep, otherwise you'll get compile errors like these
http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...
Fixed with 'git cl format'(this is nice)
Could you take a look again?

[magjed_webrtc, 2015-10-20 15:37:24]

On 2015/10/20 14:40:22, olga wrote:
> Yep, otherwise you'll get compile errors like these
>
http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...
> Fixed with 'git cl format'(this is nice)
> Could you take a look again?

I see, this issue was more complicated than I thought then. Nice fix! lgtm

[magjed_webrtc, 2015-10-20 15:39:27]

lgtm if you fix the nit. Press the 'Commit' checkbox when you are done.

https://codereview.webrtc.org/1414703002/diff/60001/talk/app/webrtc/java/jni/...
File talk/app/webrtc/java/jni/androidvideocapturer_jni.h (right):

https://codereview.webrtc.org/1414703002/diff/60001/talk/app/webrtc/java/jni/...
talk/app/webrtc/java/jni/androidvideocapturer_jni.h:74: // To avoid deducing
Args from the 3rd parameter of AsyncCapturerInvoke
nit: You should have a dot '.' at the of the sentence.

[olka_webrtc, 2015-10-20 15:45:27]

The CQ bit was checked by olka@webrtc.org

[olka_webrtc, 2015-10-20 15:45:28]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1414703002/#ps80001 (title:
"fixing punctuation")

[commit-bot: I haz the power, 2015-10-20 15:45:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414703002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414703002/80001

[olka_webrtc, 2015-10-20 15:46:52]

done!

[commit-bot: I haz the power, 2015-10-20 15:50:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-20 15:50:01]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/1319)

[magjed_webrtc, 2015-10-20 15:52:32]

On 2015/10/20 15:46:52, olga wrote:
> done!

I realize now that I'm not an owner of talk/app/webrtc/androidvideocapturer.*
You can add tommi@google.com as reviewer for those files. You can run 'git cl
owners' to get help with which reviewers you need for your CL.

[olka_webrtc, 2015-10-20 15:53:01]

olka@webrtc.org changed reviewers:
+ tommi@webrtc.org

[olka_webrtc, 2015-10-20 15:53:01]

Owner's lgtm is required for commit - adding Tommi

[olka_webrtc, 2015-10-20 15:54:24]

> I realize now that I'm not an owner of talk/app/webrtc/androidvideocapturer.*
> You can add mailto:tommi@google.com as reviewer for those files. You can run
'git cl
> owners' to get help with which reviewers you need for your CL.

Yep, I've just read your thoughts (and presubmit log) and did it :)

[tommi, 2015-10-20 16:14:14]

nice fix for the build error. lgtm.

[tommi, 2015-10-20 16:14:19]

The CQ bit was checked by tommi@webrtc.org

[commit-bot: I haz the power, 2015-10-20 16:14:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414703002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414703002/80001

[commit-bot: I haz the power, 2015-10-20 18:04:59]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2015-10-20 18:05:14]

Patchset 3 (id:??) landed as
https://crrev.com/30a5b5e9fb574016ced1a45ae43921c1a01860a0
Cr-Commit-Position: refs/heads/master@{#10342}