Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1414573002: Update iOS merge script. (Closed)

Created:
5 years, 2 months ago by tkchin_webrtc
Modified:
5 years, 2 months ago
Reviewers:
jiayl2, Chuck
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update iOS merge script. BUG= Committed: https://crrev.com/dd2bd26b6d80fe23147ad68dc9ede020b0c4337c Cr-Commit-Position: refs/heads/master@{#10326}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -16 lines) Patch
M talk/build/merge_ios_libs View 2 chunks +26 lines, -16 lines 0 comments Download
M talk/build/merge_ios_libs.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
tkchin_webrtc
5 years, 2 months ago (2015-10-16 22:59:14 UTC) #2
Chuck
LGTM
5 years, 2 months ago (2015-10-19 14:50:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414573002/1
5 years, 2 months ago (2015-10-19 15:47:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/1298)
5 years, 2 months ago (2015-10-19 15:49:51 UTC) #7
tkchin_webrtc
jiayl@ mind rubber stamping?
5 years, 2 months ago (2015-10-19 16:34:58 UTC) #9
jiayl2
lgtm
5 years, 2 months ago (2015-10-19 16:49:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414573002/1
5 years, 2 months ago (2015-10-19 18:19:32 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-19 19:53:56 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 19:54:18 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/dd2bd26b6d80fe23147ad68dc9ede020b0c4337c
Cr-Commit-Position: refs/heads/master@{#10326}

Powered by Google App Engine
This is Rietveld 408576698