Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 1414563003: Remove time constraint on first retransmit of a packet. (Closed)

Created:
5 years, 2 months ago by sprang_webrtc
Modified:
5 years, 2 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove time constraint on first retransmit of a packet. We don't allow more than one retransmission within one RTT, but the RTT estimate might be off. Reasonably, the remote end will not send a NACK until the packet after has been received - so always resend on first request. Committed: https://crrev.com/affa39cb39c77408109fef691533021533d969e1 Cr-Commit-Position: refs/heads/master@{#10362}

Patch Set 1 #

Patch Set 2 : Updated unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -19 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_packet_history.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet_history.cc View 4 chunks +15 lines, -9 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet_history_unittest.cc View 1 2 chunks +44 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
sprang_webrtc
5 years, 2 months ago (2015-10-19 13:54:15 UTC) #2
stefan-webrtc
lgtm
5 years, 2 months ago (2015-10-21 14:13:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414563003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414563003/20001
5 years, 2 months ago (2015-10-21 14:58:28 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
5 years, 2 months ago (2015-10-21 16:58:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414563003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414563003/20001
5 years, 2 months ago (2015-10-21 20:45:29 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-21 20:46:37 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-21 20:46:51 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/affa39cb39c77408109fef691533021533d969e1
Cr-Commit-Position: refs/heads/master@{#10362}

Powered by Google App Engine
This is Rietveld 408576698