Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Issue 1414543002: Add back an override of RestoreOriginalPacket. (Closed)

Created:
5 years, 2 months ago by noahric
Modified:
5 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add back an override of RestoreOriginalPacket. External consumers may have a dependency on the old name, so this will give them the opportunity to switch over. BUG= Committed: https://crrev.com/3eab10d629a5f549ddd62ec3053088205155d5b8 Cr-Commit-Position: refs/heads/master@{#10310}

Patch Set 1 #

Patch Set 2 : Add comment about deprecation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M webrtc/modules/rtp_rtcp/interface/rtp_payload_registry.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_payload_registry.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
noahric
Added back the old RestoreOriginalPacket as an overload that just calls the new one. When ...
5 years, 2 months ago (2015-10-16 21:17:50 UTC) #2
stefan-webrtc
lgtm
5 years, 2 months ago (2015-10-17 07:21:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414543002/20001
5 years, 2 months ago (2015-10-17 07:22:10 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-17 08:06:45 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/3eab10d629a5f549ddd62ec3053088205155d5b8 Cr-Commit-Position: refs/heads/master@{#10310}
5 years, 2 months ago (2015-10-17 08:06:53 UTC) #8
minyue-webrtc
5 years, 2 months ago (2015-10-17 19:18:50 UTC) #9
Message was sent while issue was closed.
On 2015/10/17 08:06:53, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/3eab10d629a5f549ddd62ec3053088205155d5b8
> Cr-Commit-Position: refs/heads/master@{#10310}

Thank you!

Powered by Google App Engine
This is Rietveld 408576698