Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 1414363002: Exposing DTLS transport state from TransportChannel. (Closed)

Created:
5 years, 2 months ago by Taylor Brandstetter
Modified:
5 years, 1 month ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Exposing DTLS transport state from TransportChannel. This is necessary in order to support the RTCPeerConnectionState enum in the future, as well as a correct RTCIceConnectionState (which isn't a combination ICE and DTLS state). Committed: https://crrev.com/2b5586774ca71b19cbebc38c96d1476ccb3dfdb4 Cr-Commit-Position: refs/heads/master@{#10419}

Patch Set 1 #

Patch Set 2 : Renaming, fixing comment. #

Total comments: 12

Patch Set 3 : Got rid of the duplicated DTLS state enum. #

Patch Set 4 : Fixing some comments. #

Total comments: 12

Patch Set 5 : Small cleanup. #

Patch Set 6 : Fixing Windows compiler warning. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -131 lines) Patch
M webrtc/p2p/base/dtlstransportchannel.h View 1 2 3 3 chunks +5 lines, -11 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel.cc View 1 2 3 4 5 21 chunks +100 lines, -112 lines 0 comments Download
M webrtc/p2p/base/transport.h View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M webrtc/p2p/base/transportchannel.h View 1 2 3 chunks +9 lines, -0 lines 0 comments Download
M webrtc/p2p/base/transportchannel.cc View 1 2 1 chunk +19 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
Taylor Brandstetter
5 years, 2 months ago (2015-10-20 20:09:04 UTC) #2
pthatcher1
https://codereview.webrtc.org/1414363002/diff/20001/webrtc/p2p/base/dtlstransportchannel.cc File webrtc/p2p/base/dtlstransportchannel.cc (right): https://codereview.webrtc.org/1414363002/diff/20001/webrtc/p2p/base/dtlstransportchannel.cc#newcode580 webrtc/p2p/base/dtlstransportchannel.cc:580: set_dtls_transport_state(DTLS_TRANSPORT_CONNECTING); Please see if we can reduce down to ...
5 years, 2 months ago (2015-10-20 20:28:07 UTC) #3
Taylor Brandstetter
Here's my pass at merging the DTLS states. "STATE_NONE" becomes "!dtls_active_" (which I think is ...
5 years, 2 months ago (2015-10-21 16:28:16 UTC) #4
pthatcher1
I like it. Just some little cleanup could be done. https://codereview.webrtc.org/1414363002/diff/60001/webrtc/p2p/base/dtlstransportchannel.cc File webrtc/p2p/base/dtlstransportchannel.cc (right): https://codereview.webrtc.org/1414363002/diff/60001/webrtc/p2p/base/dtlstransportchannel.cc#newcode351 ...
5 years, 2 months ago (2015-10-22 07:05:00 UTC) #5
Taylor Brandstetter
https://codereview.webrtc.org/1414363002/diff/60001/webrtc/p2p/base/dtlstransportchannel.cc File webrtc/p2p/base/dtlstransportchannel.cc (right): https://codereview.webrtc.org/1414363002/diff/60001/webrtc/p2p/base/dtlstransportchannel.cc#newcode351 webrtc/p2p/base/dtlstransportchannel.cc:351: result = -1; On 2015/10/22 07:05:00, pthatcher1 wrote: > ...
5 years, 1 month ago (2015-10-22 19:30:26 UTC) #6
pthatcher1
lgtm
5 years, 1 month ago (2015-10-22 23:16:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414363002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414363002/100001
5 years, 1 month ago (2015-10-26 22:40:54 UTC) #9
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 1 month ago (2015-10-27 00:23:32 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 00:23:44 UTC) #11
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/2b5586774ca71b19cbebc38c96d1476ccb3dfdb4
Cr-Commit-Position: refs/heads/master@{#10419}

Powered by Google App Engine
This is Rietveld 408576698