Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1414313003: Reland of Adding the ability to change ICE servers through SetConfiguration. (Closed)

Created:
5 years, 1 month ago by Taylor Brandstetter
Modified:
5 years, 1 month ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Adding the ability to change ICE servers through SetConfiguration. (patchset #1 id:1 of https://codereview.webrtc.org/1424803004/ ) Reason for revert: Relanding with compile warning fixed. Original issue's description: > Revert of Adding the ability to change ICE servers through SetConfiguration. (patchset #7 id:120001 of https://codereview.webrtc.org/1391013007/ ) > > Reason for revert: > Caused compiler warning, breaking Chrome FYI bots. > > Original issue's description: > > Adding the ability to change ICE servers through SetConfiguration. > > > > Added a SetIceServers method to PortAllocator. Also added a new > > PeerConnection Initialize method that takes a PortAllocator, in the > > hope that we can get rid of PortAllocatorFactoryInterface, since the > > only substantial thing a factory does is convert the webrtc:: ICE > > servers to cricket:: versions. > > > > Committed: https://crrev.com/d3b26d94399ff539db375a9b84010ee75479d4cf > > Cr-Commit-Position: refs/heads/master@{#10420} > > TBR=pthatcher@webrtc.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/18a944bf0ac9eed872dc009bd58e6bc12c946303 > Cr-Commit-Position: refs/heads/master@{#10421} TBR=pthatcher@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/653b8e02f22c9b6ba38be1cf4c0fa101894a9407 Cr-Commit-Position: refs/heads/master@{#10609}

Patch Set 1 #

Patch Set 2 : Adding "override" to applicable methods to fix compile warning. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -113 lines) Patch
M talk/app/webrtc/fakeportallocatorfactory.h View 1 3 chunks +10 lines, -1 line 0 comments Download
M talk/app/webrtc/peerconnection.h View 1 1 chunk +10 lines, -0 lines 0 comments Download
M talk/app/webrtc/peerconnection.cc View 1 3 chunks +70 lines, -32 lines 0 comments Download
M talk/app/webrtc/peerconnectioninterface_unittest.cc View 1 1 chunk +17 lines, -0 lines 0 comments Download
M talk/app/webrtc/portallocatorfactory.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download
M talk/app/webrtc/webrtcsession_unittest.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel_unittest.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
M webrtc/p2p/base/portallocator.h View 1 3 chunks +27 lines, -0 lines 0 comments Download
M webrtc/p2p/client/basicportallocator.h View 1 7 chunks +21 lines, -36 lines 0 comments Download
M webrtc/p2p/client/basicportallocator.cc View 1 3 chunks +13 lines, -8 lines 0 comments Download
M webrtc/p2p/client/fakeportallocator.h View 1 2 chunks +16 lines, -1 line 0 comments Download
M webrtc/p2p/client/portallocator_unittest.cc View 1 4 chunks +18 lines, -19 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
Taylor Brandstetter
Created Reland of Adding the ability to change ICE servers through SetConfiguration.
5 years, 1 month ago (2015-10-27 02:38:47 UTC) #1
Taylor Brandstetter
bump
5 years, 1 month ago (2015-11-11 00:19:17 UTC) #2
pthatcher1
lgtm
5 years, 1 month ago (2015-11-11 00:45:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414313003/230001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414313003/230001
5 years, 1 month ago (2015-11-11 20:54:58 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:230001)
5 years, 1 month ago (2015-11-11 20:55:16 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/653b8e02f22c9b6ba38be1cf4c0fa101894a9407 Cr-Commit-Position: refs/heads/master@{#10609}
5 years, 1 month ago (2015-11-11 20:55:28 UTC) #7
tommi
On 2015/11/11 20:55:28, commit-bot: I haz the power wrote: > Patchset 2 (id:??) landed as ...
5 years, 1 month ago (2015-11-13 17:01:57 UTC) #8
tommi
5 years, 1 month ago (2015-11-13 17:16:01 UTC) #9
Message was sent while issue was closed.
On 2015/11/13 at 17:01:57, tommi (webrtc) wrote:
> On 2015/11/11 20:55:28, commit-bot: I haz the power wrote:
> > Patchset 2 (id:??) landed as
> > https://crrev.com/653b8e02f22c9b6ba38be1cf4c0fa101894a9407
> > Cr-Commit-Position: refs/heads/master@{#10609}
> 
> Out of curiosity, why bypassing all the checks?
> 
> TBR=pthatcher@webrtc.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true

nevermind, the multiple reverts confused me.

Powered by Google App Engine
This is Rietveld 408576698