Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Issue 1414243003: DtlsIdentityStoreInterface::RequestIdentity with rtc::KeyParams (Closed)

Created:
5 years, 2 months ago by hbos
Modified:
5 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

New DtlsIdentityStoreInterface::RequestIdentity added that takes rtc::KeyParams. The old RequestIdentity still exists that take rtc::KeyType. Default implementation added that invokes the other RequestIdentity method, adding default parameters or dropping the parameters. This CL is in preparation for removing the RequestIdentity that takes rtc::KeyType, necessary as to not break Chromium. BUG=webrtc:4927, 528250 Committed: https://crrev.com/3b7c7935749a955996575e11e718603e4c8cd3a6 Cr-Commit-Position: refs/heads/master@{#10351}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M talk/app/webrtc/dtlsidentitystore.h View 1 chunk +16 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
hbos
PTAL torbjorng, tommi. Preferrably quickly, it's a tiny CL that doesn't change functionality but the ...
5 years, 2 months ago (2015-10-21 07:24:03 UTC) #4
tommi
lgtm
5 years, 2 months ago (2015-10-21 08:16:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414243003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414243003/20001
5 years, 2 months ago (2015-10-21 08:43:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 2 months ago (2015-10-21 08:44:26 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-21 08:44:37 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3b7c7935749a955996575e11e718603e4c8cd3a6
Cr-Commit-Position: refs/heads/master@{#10351}

Powered by Google App Engine
This is Rietveld 408576698