Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1414093003: Suppress libyuv::TestCpuFlag races. (Closed)

Created:
5 years, 2 months ago by pbos-webrtc
Modified:
5 years, 2 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Suppress libyuv::TestCpuFlag races. Two concurrently running decoders will trigger data races on cpu_info_ which is lazily initialized on reading TestCpuFlag without proper atomics. BUG=libyuv:508 R=kjellander@webrtc.org TEST=Running EndToEndTest.SendsAndReceivesMultipleStreams under TSan. Committed: https://crrev.com/7ae926274593c7965f3559d4cb698b0f40dfd8ef Cr-Commit-Position: refs/heads/master@{#10335}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M webrtc/build/sanitizers/tsan_suppressions_webrtc.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pbos-webrtc
PTAL
5 years, 2 months ago (2015-10-20 10:10:23 UTC) #1
kjellander_webrtc
lgtm
5 years, 2 months ago (2015-10-20 11:08:01 UTC) #4
pbos-webrtc
Committed patchset #1 (id:1) manually as 7ae926274593c7965f3559d4cb698b0f40dfd8ef (presubmit successful).
5 years, 2 months ago (2015-10-20 11:37:47 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 11:37:49 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7ae926274593c7965f3559d4cb698b0f40dfd8ef
Cr-Commit-Position: refs/heads/master@{#10335}

Powered by Google App Engine
This is Rietveld 408576698