Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 1414053003: Remove final from rtc::Buffer. (Closed)

Created:
5 years, 2 months ago by noahric
Modified:
5 years, 2 months ago
Reviewers:
tommi, kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove final from rtc::Buffer. With it removed, you can now use it with scoped_refptr by wrapping it in an rtc::RefCountedObject<rtc::Buffer>. BUG= Committed: https://crrev.com/27dfe201a55b345c17ca4586a5a5a3a9ab245ee9 Cr-Commit-Position: refs/heads/master@{#10386}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/base/buffer.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
noahric
5 years, 2 months ago (2015-10-22 21:08:41 UTC) #2
kwiberg-webrtc
lgtm As discussed in a previous incarnation of this CL that is no longer with ...
5 years, 2 months ago (2015-10-22 21:12:51 UTC) #3
noahric
On 2015/10/22 21:12:51, kwiberg-webrtc wrote: > lgtm > > As discussed in a previous incarnation ...
5 years, 2 months ago (2015-10-22 21:16:34 UTC) #4
tommi
lgtm
5 years, 2 months ago (2015-10-23 12:56:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414053003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414053003/1
5 years, 2 months ago (2015-10-23 12:56:17 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 13:01:14 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 13:01:23 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/27dfe201a55b345c17ca4586a5a5a3a9ab245ee9
Cr-Commit-Position: refs/heads/master@{#10386}

Powered by Google App Engine
This is Rietveld 408576698