Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 1413773005: Remove noparent from talk/OWNERS. (Closed)

Created:
5 years, 2 months ago by pbos-webrtc
Modified:
5 years, 1 month ago
Reviewers:
juberti1, pthatcher1
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove noparent from talk/OWNERS. Lets webrtc root OWNERS approve talk/ code as well. BUG= R=pthatcher@webrtc.org Committed: https://crrev.com/27f6fd346accd7a96ff2efde4af3a80509b1b92f Cr-Commit-Position: refs/heads/master@{#10427}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M talk/OWNERS View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
pbos-webrtc
PTAL, since we're (slowly) working towards moving talk/ code into webrtc/ this separation doesn't make ...
5 years, 2 months ago (2015-10-19 08:47:28 UTC) #1
juberti
On 2015/10/19 08:47:28, pbos-webrtc wrote: > PTAL, since we're (slowly) working towards moving talk/ code ...
5 years, 2 months ago (2015-10-24 01:17:30 UTC) #2
pbos-webrtc
Cool, is this something you think makes sense Peter?
5 years, 1 month ago (2015-10-25 20:56:05 UTC) #5
pthatcher1
lgtm
5 years, 1 month ago (2015-10-26 18:47:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413773005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413773005/1
5 years, 1 month ago (2015-10-26 19:03:37 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years, 1 month ago (2015-10-26 21:03:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413773005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413773005/1
5 years, 1 month ago (2015-10-27 11:04:22 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-27 11:08:16 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 11:08:25 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/27f6fd346accd7a96ff2efde4af3a80509b1b92f
Cr-Commit-Position: refs/heads/master@{#10427}

Powered by Google App Engine
This is Rietveld 408576698