Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1508)

Unified Diff: talk/session/media/channelmanager.h

Issue 1413483003: Added option to specify a maximum file size when recording an AEC dump. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Addressed more review comments. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/session/media/channelmanager.h
diff --git a/talk/session/media/channelmanager.h b/talk/session/media/channelmanager.h
index 241766245214b08231798c8406cb41ae9d9c544a..b91ee36c25485cffffb26b5e9c3ca57a77c03315 100644
--- a/talk/session/media/channelmanager.h
+++ b/talk/session/media/channelmanager.h
@@ -167,8 +167,10 @@ class ChannelManager : public rtc::MessageHandler,
// The operations below occur on the main thread.
- // Starts AEC dump using existing file.
- bool StartAecDump(rtc::PlatformFile file);
+ // Starts AEC dump using existing file, with a specified maximum file size in
+ // bytes. When the limit is reached, logging will stop and the file will be
+ // closed. If max_size_bytes is set to <= 0, no limit will be used.
+ bool StartAecDump(rtc::PlatformFile file, int64_t max_size_bytes);
// Starts RtcEventLog using existing file.
bool StartRtcEventLog(rtc::PlatformFile file);

Powered by Google App Engine
This is Rietveld 408576698