talk/media/webrtc/webrtcvoiceengine.h - Issue 1413483003: Added option to specify a maximum file size when recording an AEC dump.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/media/webrtc/webrtcvoiceengine.h

Issue 1413483003: Added option to specify a maximum file size when recording an AEC dump. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Addressed more review comments. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « talk/media/webrtc/fakewebrtcvoiceengine.h ('k') | talk/media/webrtc/webrtcvoiceengine.cc » ('j') | webrtc/modules/audio_processing/audio_processing_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: talk/media/webrtc/webrtcvoiceengine.h

diff --git a/talk/media/webrtc/webrtcvoiceengine.h b/talk/media/webrtc/webrtcvoiceengine.h

index a70840565b433c6188152eecd41719d416ee2cf2..6e3c26a45c16d9341843a312a844e6507eda18ac 100644

--- a/talk/media/webrtc/webrtcvoiceengine.h

+++ b/talk/media/webrtc/webrtcvoiceengine.h

@@ -105,8 +105,11 @@ class WebRtcVoiceEngine

// Set the external ADM. This can only be called before Init.

bool SetAudioDeviceModule(webrtc::AudioDeviceModule* adm);

- // Starts AEC dump using existing file.

- bool StartAecDump(rtc::PlatformFile file);

+ // Starts AEC dump using an existing file. A maximum file size in bytes can be

+ // specified. When the maximum file size is reached, logging is stopped and

+ // the file is closed. If max_size_bytes is set to <= 0, no limit will be

+ // used.

+ bool StartAecDump(rtc::PlatformFile file, int64_t max_size_bytes);

// Starts recording an RtcEventLog using an existing file until 10 minutes

// pass or the StopRtcEventLog function is called.