Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Unified Diff: talk/media/base/mediaengine.h

Issue 1413483003: Added option to specify a maximum file size when recording an AEC dump. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Addressed more review comments. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/media/base/mediaengine.h
diff --git a/talk/media/base/mediaengine.h b/talk/media/base/mediaengine.h
index c5b90962f9730e90965d91a0b585b77b7e256bfd..ecf98ad439061697cb1cf70b4d530a59bbe26795 100644
--- a/talk/media/base/mediaengine.h
+++ b/talk/media/base/mediaengine.h
@@ -119,8 +119,10 @@ class MediaEngineInterface {
virtual void SetVoiceLogging(int min_sev, const char* filter) = 0;
virtual void SetVideoLogging(int min_sev, const char* filter) = 0;
- // Starts AEC dump using existing file.
- virtual bool StartAecDump(rtc::PlatformFile file) = 0;
+ // Starts AEC dump using existing file, a maximum file size in bytes can be
+ // specified. Logging is stopped just before the size limit is exceeded.
+ // If max_size_bytes is set to a value <= 0, no limit will be used.
+ virtual bool StartAecDump(rtc::PlatformFile file, int64_t max_size_bytes) = 0;
// Starts RtcEventLog using existing file.
virtual bool StartRtcEventLog(rtc::PlatformFile file) = 0;
@@ -221,8 +223,8 @@ class CompositeMediaEngine : public MediaEngineInterface {
video_.SetLogging(min_sev, filter);
}
- virtual bool StartAecDump(rtc::PlatformFile file) {
- return voice_.StartAecDump(file);
+ virtual bool StartAecDump(rtc::PlatformFile file, int64_t max_size_bytes) {
+ return voice_.StartAecDump(file, max_size_bytes);
}
virtual bool StartRtcEventLog(rtc::PlatformFile file) {
@@ -262,7 +264,9 @@ class NullVoiceEngine {
return rtp_header_extensions_;
}
void SetLogging(int min_sev, const char* filter) {}
- bool StartAecDump(rtc::PlatformFile file) { return false; }
+ bool StartAecDump(rtc::PlatformFile file, int64_t max_size_bytes) {
+ return false;
+ }
bool StartRtcEventLog(rtc::PlatformFile file) { return false; }
void StopRtcEventLog() {}

Powered by Google App Engine
This is Rietveld 408576698