talk/app/webrtc/peerconnectionfactory.h - Issue 1413483003: Added option to specify a maximum file size when recording an AEC dump.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/app/webrtc/peerconnectionfactory.h

Issue 1413483003: Added option to specify a maximum file size when recording an AEC dump. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Addressed more review comments. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: talk/app/webrtc/peerconnectionfactory.h

diff --git a/talk/app/webrtc/peerconnectionfactory.h b/talk/app/webrtc/peerconnectionfactory.h

index f8e0a40de2111d83d9cf530ba0d59f1e89109333..d7c683dfb5827c1650f6274fc456aedc63811cc7 100644

--- a/talk/app/webrtc/peerconnectionfactory.h

+++ b/talk/app/webrtc/peerconnectionfactory.h

@@ -79,7 +79,7 @@ class PeerConnectionFactory : public PeerConnectionFactoryInterface {

CreateAudioTrack(const std::string& id,

AudioSourceInterface* audio_source) override;

- bool StartAecDump(rtc::PlatformFile file) override;

+ bool StartAecDump(rtc::PlatformFile file, int64_t max_size_bytes) override;

bool StartRtcEventLog(rtc::PlatformFile file) override;

void StopRtcEventLog() override;

« no previous file with comments | « no previous file | talk/app/webrtc/peerconnectionfactory.cc » ('j') | webrtc/modules/audio_processing/audio_processing_impl.h » ('J')