Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Unified Diff: webrtc/modules/audio_processing/include/audio_processing.h

Issue 1413483003: Added option to specify a maximum file size when recording an AEC dump. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Initial version Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_processing/include/audio_processing.h
diff --git a/webrtc/modules/audio_processing/include/audio_processing.h b/webrtc/modules/audio_processing/include/audio_processing.h
index 318b2f89533652b6fd1ad896d269f78deb0d004d..adb92a84a72389be9f0b9cb5d2f7a49f1b3ff4bf 100644
--- a/webrtc/modules/audio_processing/include/audio_processing.h
+++ b/webrtc/modules/audio_processing/include/audio_processing.h
@@ -393,10 +393,19 @@ class AudioProcessing {
static const size_t kMaxFilenameSize = 1024;
virtual int StartDebugRecording(const char filename[kMaxFilenameSize]) = 0;
+ // Same as above, but a maximum file size (in bytes) for the log can be
+ // specified. The logging is stopped once the limit has been reached.
+ virtual int StartDebugRecording(const char filename[kMaxFilenameSize],
the sun 2015/10/26 10:37:20 Consolidate to one interface, but keep a forwardin
ivoc 2015/11/05 13:14:46 Done.
+ int max_log_size_bytes) = 0;
+
// Same as above but uses an existing file handle. Takes ownership
// of |handle| and closes it at StopDebugRecording().
virtual int StartDebugRecording(FILE* handle) = 0;
+ // Same as above, but a maximum file size (in bytes) for the log can be
+ // specified. The logging is stopped once the limit has been reached.
+ virtual int StartDebugRecording(FILE* handle, int max_log_size_bytes) = 0;
+
// Same as above but uses an existing PlatformFile handle. Takes ownership
// of |handle| and closes it at StopDebugRecording().
// TODO(xians): Make this interface pure virtual.

Powered by Google App Engine
This is Rietveld 408576698