Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: talk/app/webrtc/peerconnectioninterface.h

Issue 1413483003: Added option to specify a maximum file size when recording an AEC dump. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Processed first batch of reviews. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2012 Google Inc. 3 * Copyright 2012 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
(...skipping 599 matching lines...) Expand 10 before | Expand all | Expand 10 after
610 VideoSourceInterface* source) = 0; 610 VideoSourceInterface* source) = 0;
611 611
612 // Creates an new AudioTrack. At the moment |source| can be NULL. 612 // Creates an new AudioTrack. At the moment |source| can be NULL.
613 virtual rtc::scoped_refptr<AudioTrackInterface> 613 virtual rtc::scoped_refptr<AudioTrackInterface>
614 CreateAudioTrack(const std::string& label, 614 CreateAudioTrack(const std::string& label,
615 AudioSourceInterface* source) = 0; 615 AudioSourceInterface* source) = 0;
616 616
617 // Starts AEC dump using existing file. Takes ownership of |file| and passes 617 // Starts AEC dump using existing file. Takes ownership of |file| and passes
618 // it on to VoiceEngine (via other objects) immediately, which will take 618 // it on to VoiceEngine (via other objects) immediately, which will take
619 // the ownerhip. If the operation fails, the file will be closed. 619 // the ownerhip. If the operation fails, the file will be closed.
620 // TODO(grunell): Remove when Chromium has started to use AEC in each source. 620 // A maximum file size in bytes can be specified. When the file size limit is
621 // http://crbug.com/264611. 621 // reached, logging is stopped automatically. If max_size_bytes is set to a
622 virtual bool StartAecDump(rtc::PlatformFile file) = 0; 622 // value <= 0, no limit will be used, and logging will continue until the
623 // StopAecDump function is called.
624 virtual bool StartAecDump(rtc::PlatformFile file, int64_t max_size_bytes) = 0;
623 625
624 // Starts RtcEventLog using existing file. Takes ownership of |file| and 626 // Starts RtcEventLog using existing file. Takes ownership of |file| and
625 // passes it on to VoiceEngine, which will take the ownership. If the 627 // passes it on to VoiceEngine, which will take the ownership. If the
626 // operation fails the file will be closed. The logging will stop 628 // operation fails the file will be closed. The logging will stop
627 // automatically after 10 minutes have passed, or when the StopRtcEventLog 629 // automatically after 10 minutes have passed, or when the StopRtcEventLog
628 // function is called. 630 // function is called.
629 // This function as well as the StopRtcEventLog don't really belong on this 631 // This function as well as the StopRtcEventLog don't really belong on this
630 // interface, this is a temporary solution until we move the logging object 632 // interface, this is a temporary solution until we move the logging object
631 // from inside voice engine to webrtc::Call, which will happen when the VoE 633 // from inside voice engine to webrtc::Call, which will happen when the VoE
632 // restructuring effort is further along. 634 // restructuring effort is further along.
(...skipping 22 matching lines...) Expand all
655 CreatePeerConnectionFactory( 657 CreatePeerConnectionFactory(
656 rtc::Thread* worker_thread, 658 rtc::Thread* worker_thread,
657 rtc::Thread* signaling_thread, 659 rtc::Thread* signaling_thread,
658 AudioDeviceModule* default_adm, 660 AudioDeviceModule* default_adm,
659 cricket::WebRtcVideoEncoderFactory* encoder_factory, 661 cricket::WebRtcVideoEncoderFactory* encoder_factory,
660 cricket::WebRtcVideoDecoderFactory* decoder_factory); 662 cricket::WebRtcVideoDecoderFactory* decoder_factory);
661 663
662 } // namespace webrtc 664 } // namespace webrtc
663 665
664 #endif // TALK_APP_WEBRTC_PEERCONNECTIONINTERFACE_H_ 666 #endif // TALK_APP_WEBRTC_PEERCONNECTIONINTERFACE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698