Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Side by Side Diff: talk/app/webrtc/peerconnectionfactory.cc

Issue 1413483003: Added option to specify a maximum file size when recording an AEC dump. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Processed first batch of reviews. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2004--2011 Google Inc. 3 * Copyright 2004--2011 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
(...skipping 195 matching lines...) Expand 10 before | Expand all | Expand 10 after
206 rtc::scoped_refptr<VideoSourceInterface> 206 rtc::scoped_refptr<VideoSourceInterface>
207 PeerConnectionFactory::CreateVideoSource( 207 PeerConnectionFactory::CreateVideoSource(
208 cricket::VideoCapturer* capturer, 208 cricket::VideoCapturer* capturer,
209 const MediaConstraintsInterface* constraints) { 209 const MediaConstraintsInterface* constraints) {
210 RTC_DCHECK(signaling_thread_->IsCurrent()); 210 RTC_DCHECK(signaling_thread_->IsCurrent());
211 rtc::scoped_refptr<VideoSource> source( 211 rtc::scoped_refptr<VideoSource> source(
212 VideoSource::Create(channel_manager_.get(), capturer, constraints)); 212 VideoSource::Create(channel_manager_.get(), capturer, constraints));
213 return VideoSourceProxy::Create(signaling_thread_, source); 213 return VideoSourceProxy::Create(signaling_thread_, source);
214 } 214 }
215 215
216 bool PeerConnectionFactory::StartAecDump(rtc::PlatformFile file) { 216 bool PeerConnectionFactory::StartAecDump(rtc::PlatformFile file,
217 int64_t max_size_bytes) {
217 RTC_DCHECK(signaling_thread_->IsCurrent()); 218 RTC_DCHECK(signaling_thread_->IsCurrent());
218 return channel_manager_->StartAecDump(file); 219 return channel_manager_->StartAecDump(file, max_size_bytes);
219 } 220 }
220 221
221 bool PeerConnectionFactory::StartRtcEventLog(rtc::PlatformFile file) { 222 bool PeerConnectionFactory::StartRtcEventLog(rtc::PlatformFile file) {
222 RTC_DCHECK(signaling_thread_->IsCurrent()); 223 RTC_DCHECK(signaling_thread_->IsCurrent());
223 return channel_manager_->StartRtcEventLog(file); 224 return channel_manager_->StartRtcEventLog(file);
224 } 225 }
225 226
226 void PeerConnectionFactory::StopRtcEventLog() { 227 void PeerConnectionFactory::StopRtcEventLog() {
227 RTC_DCHECK(signaling_thread_->IsCurrent()); 228 RTC_DCHECK(signaling_thread_->IsCurrent());
228 channel_manager_->StopRtcEventLog(); 229 channel_manager_->StopRtcEventLog();
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
308 } 309 }
309 310
310 cricket::MediaEngineInterface* PeerConnectionFactory::CreateMediaEngine_w() { 311 cricket::MediaEngineInterface* PeerConnectionFactory::CreateMediaEngine_w() {
311 ASSERT(worker_thread_ == rtc::Thread::Current()); 312 ASSERT(worker_thread_ == rtc::Thread::Current());
312 return cricket::WebRtcMediaEngineFactory::Create( 313 return cricket::WebRtcMediaEngineFactory::Create(
313 default_adm_.get(), video_encoder_factory_.get(), 314 default_adm_.get(), video_encoder_factory_.get(),
314 video_decoder_factory_.get()); 315 video_decoder_factory_.get());
315 } 316 }
316 317
317 } // namespace webrtc 318 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698