Issue 1413423002: Revert of Bug 4517: Enable connectivity for demo page when no STUN/TURN specifiefd.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1413423002: Revert of Bug 4517: Enable connectivity for demo page when no STUN/TURN specifiefd. (Closed)

Created:
5 years, 2 months ago by guoweis_webrtc

Modified:
5 years, 1 month ago

Reviewers:
pthather, jubert, pthatcher1

CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom

Base URL:
https://chromium.googlesource.com/external/webrtc@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

Revert of Bug 4517: Enable connectivity for demo page when no STUN/TURN specifiefd. (patchset #6 id:140001 of https://codereview.webrtc.org/1275703006/ ) Reason for revert: Generate a revert CL since we don't need this loopback address anymore. This is not sent to CQ. Original issue's description: > Generate localhost candidate when no STUN/TURN and portallocator has the right flag spefied. > > BUG=webrtc:4517 > R=pthatcher@webrtc.org > > Committed: https://chromium.googlesource.com/external/webrtc/+/0a2955f227666efd87b2a303a69c083ef801c528 TBR=jubert@webrtc.org,pthather@webrtc.org,pthatcher@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4517

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -143 lines)			Patch
M	talk/app/webrtc/peerconnectioninterface.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	talk/app/webrtc/webrtcsession.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	webrtc/base/ipaddress.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	webrtc/base/ipaddress.cc	View	1 chunk	+1 line, -10 lines	0 comments	Download
M	webrtc/p2p/base/port_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webrtc/p2p/base/portallocator.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	webrtc/p2p/base/stunport.h	View	6 chunks	+7 lines, -17 lines	0 comments	Download
M	webrtc/p2p/base/stunport.cc	View	4 chunks	+7 lines, -20 lines	0 comments	Download
M	webrtc/p2p/base/stunport_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webrtc/p2p/base/turnport_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webrtc/p2p/client/basicportallocator.cc	View	2 chunks	+12 lines, -19 lines	0 comments	Download
M	webrtc/p2p/client/fakeportallocator.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	webrtc/p2p/client/portallocator_unittest.cc	View	9 chunks	+17 lines, -58 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

guoweis_webrtc

5 years, 2 months ago (2015-10-20 17:17:58 UTC) #1

Created Revert of Bug 4517: Enable connectivity for demo page when no STUN/TURN
specifiefd.

Expand Messages | Collapse Messages