Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Issue 1413093002: Lock scheme #6: Preparational work before introducing the locks in order to harmonize the code (Closed)

Created:
5 years, 2 months ago by peah-webrtc
Modified:
5 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, hlundin-webrtc, kwiberg-webrtc, the sun, aluebs-webrtc, bjornv1, ivoc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@introduce_queue_agc_CL
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Preparational work before introducing the locks in order to harmonize the code: -Moved the initialize function -Moved api_format into the shared state BUG= Committed: https://crrev.com/192164eebc9bbb5c5745f19330b203174304e269 Cr-Commit-Position: refs/heads/master@{#10668}

Patch Set 1 #

Patch Set 2 : Merge #

Total comments: 2

Patch Set 3 : Merge from other CLs in the list #

Patch Set 4 : Merged with latest master #

Messages

Total messages: 12 (4 generated)
peah-webrtc
5 years, 1 month ago (2015-10-26 09:22:09 UTC) #3
kwiberg-webrtc
lgtm https://codereview.webrtc.org/1413093002/diff/20001/webrtc/modules/audio_processing/audio_processing_impl.h File webrtc/modules/audio_processing/audio_processing_impl.h (right): https://codereview.webrtc.org/1413093002/diff/20001/webrtc/modules/audio_processing/audio_processing_impl.h#newcode180 webrtc/modules/audio_processing/audio_processing_impl.h:180: // but can be read while holding only ...
5 years, 1 month ago (2015-10-26 11:02:46 UTC) #4
the sun
lgtm
5 years, 1 month ago (2015-10-29 09:49:57 UTC) #5
peah-webrtc
https://codereview.webrtc.org/1413093002/diff/20001/webrtc/modules/audio_processing/audio_processing_impl.h File webrtc/modules/audio_processing/audio_processing_impl.h (right): https://codereview.webrtc.org/1413093002/diff/20001/webrtc/modules/audio_processing/audio_processing_impl.h#newcode180 webrtc/modules/audio_processing/audio_processing_impl.h:180: // but can be read while holding only one ...
5 years, 1 month ago (2015-10-29 14:28:02 UTC) #6
hlundin-webrtc
lgtm
5 years, 1 month ago (2015-10-30 08:09:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413093002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413093002/60001
5 years, 1 month ago (2015-11-17 09:20:56 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 1 month ago (2015-11-17 10:16:50 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 10:17:03 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/192164eebc9bbb5c5745f19330b203174304e269
Cr-Commit-Position: refs/heads/master@{#10668}

Powered by Google App Engine
This is Rietveld 408576698