Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 1412833004: Fix HW video codec stack traces reporting. (Closed)

Created:
5 years, 2 months ago by AlexG
Modified:
5 years, 2 months ago
Reviewers:
wzh
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix HW video codec stack traces reporting. Print stack traces for active instance only. Also add Nexus 4 to H.264 encoder blacklist. R=wzh@webrtc.org Committed: https://crrev.com/c6aec4b8edba5c003966a53f20b5e26cb8c7b8ce Cr-Commit-Position: refs/heads/master@{#10329}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -11 lines) Patch
M talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoDecoder.java View 1 5 chunks +7 lines, -5 lines 0 comments Download
M talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoEncoder.java View 1 6 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
AlexG
PTAL
5 years, 2 months ago (2015-10-19 22:55:57 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412833004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412833004/1
5 years, 2 months ago (2015-10-19 22:59:23 UTC) #4
wzh
https://codereview.webrtc.org/1412833004/diff/1/talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoDecoder.java File talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoDecoder.java (right): https://codereview.webrtc.org/1412833004/diff/1/talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoDecoder.java#newcode198 talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoDecoder.java:198: private boolean initDecode(VideoCodecType type, int width, int height, EGLContext ...
5 years, 2 months ago (2015-10-19 23:01:48 UTC) #5
AlexG
https://codereview.webrtc.org/1412833004/diff/1/talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoDecoder.java File talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoDecoder.java (right): https://codereview.webrtc.org/1412833004/diff/1/talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoDecoder.java#newcode198 talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoDecoder.java:198: private boolean initDecode(VideoCodecType type, int width, int height, EGLContext ...
5 years, 2 months ago (2015-10-19 23:15:16 UTC) #6
wzh
lgtm
5 years, 2 months ago (2015-10-19 23:17:21 UTC) #7
AlexG
Committed patchset #2 (id:20001) manually as c6aec4b8edba5c003966a53f20b5e26cb8c7b8ce (presubmit successful).
5 years, 2 months ago (2015-10-19 23:39:38 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 23:39:42 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c6aec4b8edba5c003966a53f20b5e26cb8c7b8ce
Cr-Commit-Position: refs/heads/master@{#10329}

Powered by Google App Engine
This is Rietveld 408576698