Update references to TLS1_CK_ECDHE_RSA_CHACHA20_POLY1305, etc.

Update references to TLS1_CK_ECDHE_RSA_CHACHA20_POLY1305, etc.

In preparation for implementing the standardized variant of CHACHA20_POLY1305
(it changed slightly in the standardization process),
TLS1_CK_ECDHE_RSA_CHACHA20_POLY1305 and TLS1_CK_ECDHE_ECDSA_CHACHA20_POLY1305
were renamed to have an _OLD suffix with compatibility unsuffixed #defines
temporarily available.

Update references to include the _OLD suffixed ones. Once we've cycled through
the few consumers of the unsuffixed names (just WebRTC and QUIC), the unsuffixed
names can refer to the to-be-implemented standardized variant and eventually
the draft version will be removed.

(This has no effect on upstream OpenSSL compatibility as OpenSSL never defined
these symbols to begin with. Though probably they will once standardization is
done.)

BUG=none

Committed: https://crrev.com/c073615d56b8f626bf694868a276fd135898da11
Cr-Commit-Position: refs/heads/master@{#10681}

[davidben_webrtc, 2015-11-05 22:52:27]

Description was changed from

==========
Update references to TLS1_CK_ECDHE_RSA_CHACHA20_POLY1305, etc.

In preparation for implementing the standardized variant of CHACHA20_POLY1305
(it changed slightly in the standardization process), update references to
TLS1_CK_ECDHE_RSA_CHACHA20_POLY1305 and TLS1_CK_ECDHE_ECDSA_CHACHA20_POLY1305
to the _OLD suffixed ones. Once we've cycled through the few consumers of the
unsuffixed names (just WebRTC and QUIC), the unsuffixed names will refer to the
to-be-implemented standardized variant and eventually the draft version
removed.

BUG=none
==========

to

==========
Update references to TLS1_CK_ECDHE_RSA_CHACHA20_POLY1305, etc.

In preparation for implementing the standardized variant of CHACHA20_POLY1305
(it changed slightly in the standardization process),
TLS1_CK_ECDHE_RSA_CHACHA20_POLY1305 and TLS1_CK_ECDHE_ECDSA_CHACHA20_POLY1305
were renamed to have an _OLD suffix with compatibility unsuffixed #defines
temporarily available.

Update references to include the _OLD suffixed ones. Once we've cycled through
the few consumers of the unsuffixed names (just WebRTC and QUIC), the unsuffixed
names can refer to the to-be-implemented standardized variant and eventually
the draft version will be removed.

BUG=none
==========

[davidben_webrtc, 2015-11-05 22:53:16]

Description was changed from

==========
Update references to TLS1_CK_ECDHE_RSA_CHACHA20_POLY1305, etc.

In preparation for implementing the standardized variant of CHACHA20_POLY1305
(it changed slightly in the standardization process),
TLS1_CK_ECDHE_RSA_CHACHA20_POLY1305 and TLS1_CK_ECDHE_ECDSA_CHACHA20_POLY1305
were renamed to have an _OLD suffix with compatibility unsuffixed #defines
temporarily available.

Update references to include the _OLD suffixed ones. Once we've cycled through
the few consumers of the unsuffixed names (just WebRTC and QUIC), the unsuffixed
names can refer to the to-be-implemented standardized variant and eventually
the draft version will be removed.

BUG=none
==========

to

==========
Update references to TLS1_CK_ECDHE_RSA_CHACHA20_POLY1305, etc.

In preparation for implementing the standardized variant of CHACHA20_POLY1305
(it changed slightly in the standardization process),
TLS1_CK_ECDHE_RSA_CHACHA20_POLY1305 and TLS1_CK_ECDHE_ECDSA_CHACHA20_POLY1305
were renamed to have an _OLD suffix with compatibility unsuffixed #defines
temporarily available.

Update references to include the _OLD suffixed ones. Once we've cycled through
the few consumers of the unsuffixed names (just WebRTC and QUIC), the unsuffixed
names can refer to the to-be-implemented standardized variant and eventually
the draft version will be removed.

(This has no effect on upstream OpenSSL compatibility as OpenSSL never defined
these symbols to begin with. Though probably they will once standardization is
done.)

BUG=none
==========

[davidben_webrtc, 2015-11-05 22:56:14]

davidben@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[davidben_webrtc, 2015-11-05 22:56:14]

For some reason, it doesn't want to let me run try jobs. I get some permission
error.

[pthatcher2, 2015-11-16 23:24:16]

pthatcher@chromium.org changed reviewers:
+ pthatcher@chromium.org

[pthatcher2, 2015-11-16 23:24:17]

https://codereview.webrtc.org/1412803010/diff/1/webrtc/base/opensslstreamadap...
File webrtc/base/opensslstreamadapter.cc (right):

https://codereview.webrtc.org/1412803010/diff/1/webrtc/base/opensslstreamadap...
webrtc/base/opensslstreamadapter.cc:166:
static_cast<uint16_t>(TLS1_CK_ECDHE_ECDSA_CHACHA20_POLY1305_OLD);
Can we also rename this? 

Perhaps: 

kDefaultSslCipher12NoAesGcmDraft 
kDefaultSslEcCipher12NoAesGcDraft 

?

[davidben_webrtc, 2015-11-16 23:39:28]

https://codereview.webrtc.org/1412803010/diff/1/webrtc/base/opensslstreamadap...
File webrtc/base/opensslstreamadapter.cc (right):

https://codereview.webrtc.org/1412803010/diff/1/webrtc/base/opensslstreamadap...
webrtc/base/opensslstreamadapter.cc:166:
static_cast<uint16_t>(TLS1_CK_ECDHE_ECDSA_CHACHA20_POLY1305_OLD);
On 2015/11/16 23:24:17, pthatcher2 wrote:
> Can we also rename this? 
> 
> Perhaps: 
> 
> kDefaultSslCipher12NoAesGcmDraft 
> kDefaultSslEcCipher12NoAesGcDraft 
> 
> ?

I don't think we want to. This is kDefaultSslCipher12NoAesGcm as in "default ssl
cipher, when using TLS 1.2, and we have no hardware AES-GCM".

(Hrm. When we do get around to adding the non-draft cipher, there may be some
fiddling to be done here to make sure the WebRTC build isn't temporarily broken.
Meh. We'll worry about that when we get there.)

[pthatcher1, 2015-11-17 19:23:30]

lgtm

[davidben_webrtc, 2015-11-17 19:26:13]

The CQ bit was checked by davidben@webrtc.org

[commit-bot: I haz the power, 2015-11-17 19:26:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1412803010/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1412803010/1

[commit-bot: I haz the power, 2015-11-17 20:58:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-17 20:58:25]

Patchset 1 (id:??) landed as
https://crrev.com/c073615d56b8f626bf694868a276fd135898da11
Cr-Commit-Position: refs/heads/master@{#10681}