Fix bug in how send timestamps are converted to 24 bits.

Fix bug in how send timestamps are converted to 24 bits.

BUG=webrtc:4173
R=sprang@webrtc.org

Committed: https://crrev.com/0a87ffcaad6a5e8cd4ead9c4d4957bd8a77fd7f2
Cr-Commit-Position: refs/heads/master@{#10356}

[stefan-webrtc, 2015-10-20 11:42:19]

stefan@webrtc.org changed reviewers:
+ sprang@webrtc.org

[sprang_webrtc, 2015-10-20 12:33:49]

On 2015/10/20 11:42:19, stefan-webrtc (holmer) wrote:

Not entirely sure I get what was broken... How about a test?

[stefan-webrtc, 2015-10-20 19:58:16]

The CQ bit was checked by stefan@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-20 19:58:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1412683004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1412683004/1

[commit-bot: I haz the power, 2015-10-20 21:58:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-20 21:58:38]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[stefan-webrtc, 2015-10-21 09:31:26]

The CQ bit was checked by stefan@webrtc.org

[commit-bot: I haz the power, 2015-10-21 09:31:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1412683004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1412683004/40001

[commit-bot: I haz the power, 2015-10-21 09:31:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-21 09:31:36]

No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[stefan-webrtc, 2015-10-21 09:32:56]

On 2015/10/20 12:33:49, språng wrote:
> On 2015/10/20 11:42:19, stefan-webrtc (holmer) wrote:
> 
> Not entirely sure I get what was broken... How about a test?

The problem was that the division is undefined, and the behavior on Android
caused this code to misbehave. Since it's an android only issue it will be a bit
tricky to write a good test, and I don't expect this to regress anyway... I
don't think it's worth spending time on. WDYT?

[stefan-webrtc, 2015-10-21 09:33:09]

The CQ bit was checked by stefan@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-21 09:33:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1412683004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1412683004/40001

[sprang_webrtc, 2015-10-21 11:04:30]

Bummer. Good to know that this sort of thing can happen though. lgtm

[stefan-webrtc, 2015-10-21 11:25:51]

The CQ bit was unchecked by stefan@webrtc.org

[stefan-webrtc, 2015-10-21 11:25:59]

The CQ bit was checked by stefan@webrtc.org

[commit-bot: I haz the power, 2015-10-21 11:26:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1412683004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1412683004/40001

[commit-bot: I haz the power, 2015-10-21 11:33:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-21 11:33:24]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[stefan-webrtc, 2015-10-21 11:42:14]

Committed patchset #3 (id:40001) manually as
0a87ffcaad6a5e8cd4ead9c4d4957bd8a77fd7f2 (presubmit successful).

[commit-bot: I haz the power, 2015-10-21 11:42:16]

Patchset 3 (id:??) landed as
https://crrev.com/0a87ffcaad6a5e8cd4ead9c4d4957bd8a77fd7f2
Cr-Commit-Position: refs/heads/master@{#10356}