talk/libjingle.gyp - Issue 1412673008: Introduces Android API level linting, fixes all current API lint errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/libjingle.gyp

Issue 1412673008: Introduces Android API level linting, fixes all current API lint errors. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master

Patch Set: Move AndroidManifest.xml and suppressions.xml to more general location. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoEncoder.java ('k') | webrtc/build/android/AndroidManifest.xml » ('j') | webrtc/build/android/AndroidManifest.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: talk/libjingle.gyp

diff --git a/talk/libjingle.gyp b/talk/libjingle.gyp

index cd5385c11fd30067ebde77a3ee7b4aa760364f40..55787a662527572cb0b5644b213d60a3f4eb472e 100755

--- a/talk/libjingle.gyp

+++ b/talk/libjingle.gyp

@@ -227,6 +227,12 @@

'libjingle_peerconnection_so',

'variables': {

+ # Designate as Chromium code and point to our lint settings to

+ # enable linting of the WebRTC code (this is the only way to make

+ # lint_action invoke the Android linter).

+ 'android_manifest_path': '<(webrtc_root)/webrtc/build/android/AndroidManifest.xml',

+ 'suppressions_file': '<(webrtc_root)/webrtc/build/android/suppressions.xml',

+ 'chromium_code': 1,

'java_in_dir': 'app/webrtc/java',

'webrtc_base_dir': '<(webrtc_root)/base',

'webrtc_modules_dir': '<(webrtc_root)/modules',