Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 1412573010: Trace encoding/decoding time in a generic way. (Closed)

Created:
5 years, 1 month ago by pbos-webrtc
Modified:
5 years, 1 month ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Trace encoding/decoding time in a generic way. Removes VP8::Encode trace in favor of VCMGenericEncoder ones and adds one to InitEncode. Also adds an instant event to ::Encoded since this can be done on a different thread. Also adds the corresponding traces to VCMGenericDecoder. BUG=webrtc:5167 R=stefan@webrtc.org Committed: https://crrev.com/d9eec762ce8bdc90bd18a387cacae8cab90440f1 Cr-Commit-Position: refs/heads/master@{#10674}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/main/source/generic_decoder.cc View 1 3 chunks +7 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/main/source/generic_encoder.cc View 1 4 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
pbos-webrtc
PTAL woo
5 years, 1 month ago (2015-11-05 14:31:20 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412573010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412573010/1
5 years, 1 month ago (2015-11-05 14:31:36 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years, 1 month ago (2015-11-05 16:31:53 UTC) #6
stefan-webrtc
lgtm
5 years, 1 month ago (2015-11-16 19:34:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412573010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412573010/1
5 years, 1 month ago (2015-11-16 23:45:02 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_clang_dbg/builds/8918) android_dbg on tryserver.webrtc (JOB_FAILED, ...
5 years, 1 month ago (2015-11-16 23:46:33 UTC) #11
pbos-webrtc
rebase
5 years, 1 month ago (2015-11-17 11:40:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412573010/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412573010/20001
5 years, 1 month ago (2015-11-17 11:41:03 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-17 14:03:47 UTC) #16
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 14:03:57 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d9eec762ce8bdc90bd18a387cacae8cab90440f1
Cr-Commit-Position: refs/heads/master@{#10674}

Powered by Google App Engine
This is Rietveld 408576698