Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1412363004: Revert of With these changes, WebRtc x86 will build Visual Studio 2015.

Created:
5 years, 1 month ago by GeneralFault
Modified:
5 years, 1 month ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), kwiberg-webrtc, stefan-webrtc, Andrew MacDonald, hlundin-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, andresp, peah-webrtc, the sun, mflodman, perkj_webrtc, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of With these changes, WebRtc x86 will build Visual Studio 2015. (patchset #1 id:1 of https://codereview.webrtc.org/1412653006/ ) Reason for revert: Must have messed up the line endings. Will redo the changelist. Original issue's description: > With these changes, WebRtc x86 will build Visual Studio 2015. > Fixed line endings. > > > Visual Studio 2015 balks at the implicit truncation of values. Easily fixed with an implicit cast. > > > Fixed redefinition of CLOCKS_PER_SEC when using Visual Studio 2015 and the Windows 10 SDK. CLOCKS_PER_SEC is also defined in "<WIN10 SDK DIR>\include\10.0.10240.0\ucrt\time.h" and also has the value of 1000 > > > Hiding snprintf definition if building with Visual Studio 2015 > > BUG= TBR= NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -13 lines) Patch
M AUTHORS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/base/logging.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/main/test/ReleaseTest-API/ReleaseTest-API.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/main/test/simpleKenny.c View 2 chunks +1 line, -3 lines 0 comments Download
M webrtc/modules/audio_processing/transient/file_utils_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/video_engine/payload_router_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
GeneralFault
Created Revert of With these changes, WebRtc x86 will build Visual Studio 2015.
5 years, 1 month ago (2015-11-08 07:33:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412363004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412363004/1
5 years, 1 month ago (2015-11-08 07:33:07 UTC) #2
commit-bot: I haz the power
5 years, 1 month ago (2015-11-08 07:33:09 UTC) #4 
No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

Powered by Google App Engine
This is Rietveld 408576698