Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1539)

Unified Diff: webrtc/modules/pacing/paced_sender_unittest.cc

Issue 1412293003: Allow pacer to boost bitrate in order to meet time constraints. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/pacing/paced_sender_unittest.cc
diff --git a/webrtc/modules/pacing/paced_sender_unittest.cc b/webrtc/modules/pacing/paced_sender_unittest.cc
index 1e701ff8ea4cf1e9c9756873cfa504676f8080f8..efdf66299d3b77db8702ba4f8bc0823879a5127a 100644
--- a/webrtc/modules/pacing/paced_sender_unittest.cc
+++ b/webrtc/modules/pacing/paced_sender_unittest.cc
@@ -664,10 +664,10 @@ TEST_F(PacedSenderTest, ExpectedQueueTimeMs) {
EXPECT_EQ(0, send_bucket_->ExpectedQueueTimeMs());
- // Allow for aliasing, duration should be in [expected(n - 1), expected(n)].
- EXPECT_LE(duration, queue_in_ms);
- EXPECT_GE(duration,
- queue_in_ms - static_cast<int64_t>(kPacketSize * 8 / kMaxBitrate));
+ // Allow for aliasing, duration should be within one pack of max time limit.
+ EXPECT_LE(duration, PacedSender::kMaxQueueLengthMs);
+ EXPECT_GE(duration, PacedSender::kMaxQueueLengthMs -
+ static_cast<int64_t>(kPacketSize * 8 / kMaxBitrate));
stefan-webrtc 2015/10/28 15:45:23 EXPECT_NEAR(duration, PacedSender::.., kPacketSize
sprang_webrtc 2015/11/02 12:17:56 Done.
}
TEST_F(PacedSenderTest, QueueTimeGrowsOverTime) {

Powered by Google App Engine
This is Rietveld 408576698