Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1412233003: Support simulcast and spatial layers in VideoQualityTest (PERF NOTE) (Closed)

Created:
5 years, 1 month ago by sprang_webrtc
Modified:
5 years, 1 month ago
Reviewers:
pbos-webrtc, mflodman
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, andresp, peah-webrtc, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adding support for simulcast and spatial layers into VideoQualityTest This is a re-land of https://codereview.webrtc.org/1353263005/ which was reverted because of perf-regressions. Changes since that CL: * Change LayerFilteringTransport to send a padding packet instead of dropping it for data that should be filtered out. This prevents confusion due to changed sequence numbers. * Changed timing of stats poller thread in VideoAnalyzer. Startup was racy wrt initializion of send_stream_. * Minor formatting issues. PERF NOTE: This change will affect some performance numbers slightly. In particular, {encode_frame_rate, encode_time_ms, encode_usage_percent, media_bitrate_bps} will change due to timing of the measurements. BUG= R=pbos@webrtc.org TBR=mflodman@webrtc.org Committed: https://crrev.com/ce4aef16eec96862199e89b6d3ffe059558ac2c0 Cr-Commit-Position: refs/heads/master@{#10483}

Patch Set 1 #

Patch Set 2 : Rebase deluxe #

Patch Set 3 : Rebase + suppress log spamming #

Unified diffs Side-by-side diffs Delta from patch set Stats (+729 lines, -298 lines) Patch
M webrtc/common_types.h View 3 chunks +9 lines, -0 lines 0 comments Download
M webrtc/config.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc View 1 2 2 chunks +79 lines, -39 lines 0 comments Download
M webrtc/test/layer_filtering_transport.h View 1 1 chunk +8 lines, -9 lines 0 comments Download
M webrtc/test/layer_filtering_transport.cc View 1 2 3 chunks +29 lines, -31 lines 0 comments Download
M webrtc/video/full_stack.cc View 3 chunks +14 lines, -5 lines 0 comments Download
M webrtc/video/screenshare_loopback.cc View 6 chunks +110 lines, -43 lines 0 comments Download
M webrtc/video/video_loopback.cc View 6 chunks +103 lines, -40 lines 0 comments Download
M webrtc/video/video_quality_test.h View 3 chunks +38 lines, -10 lines 0 comments Download
M webrtc/video/video_quality_test.cc View 1 2 19 chunks +327 lines, -121 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
sprang_webrtc
5 years, 1 month ago (2015-10-28 09:06:45 UTC) #2
pbos-webrtc
rs-lgtm
5 years, 1 month ago (2015-10-28 14:59:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412233003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412233003/40001
5 years, 1 month ago (2015-11-02 14:22:23 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-02 15:23:24 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-02 15:23:34 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ce4aef16eec96862199e89b6d3ffe059558ac2c0
Cr-Commit-Position: refs/heads/master@{#10483}

Powered by Google App Engine
This is Rietveld 408576698