Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1412143002: Remove the video channel id completely. (Closed)

Created:
5 years, 2 months ago by mflodman
Modified:
5 years, 2 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, andresp, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove the video channel id completely. BUG=webrtc:5079 Committed: https://crrev.com/0dbf0090a961c5e5fb7362937108337564b4a91f Cr-Commit-Position: refs/heads/master@{#10324}

Patch Set 1 #

Patch Set 2 : .str #

Total comments: 2

Patch Set 3 : Remove string. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -29 lines) Patch
M webrtc/call/call.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M webrtc/video/video_receive_stream.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/video_receive_stream.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/video_send_stream.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/video_send_stream.cc View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/video_engine/encoder_state_feedback_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video_engine/vie_encoder.h View 3 chunks +1 line, -5 lines 0 comments Download
M webrtc/video_engine/vie_encoder.cc View 1 2 3 chunks +5 lines, -10 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
mflodman
5 years, 2 months ago (2015-10-19 09:48:42 UTC) #2
pbos-webrtc
lgtm, but I don't think you should have to build more strings here. https://codereview.webrtc.org/1412143002/diff/20001/webrtc/video_engine/vie_encoder.cc File ...
5 years, 2 months ago (2015-10-19 10:04:15 UTC) #3
mflodman
https://codereview.webrtc.org/1412143002/diff/20001/webrtc/video_engine/vie_encoder.cc File webrtc/video_engine/vie_encoder.cc (right): https://codereview.webrtc.org/1412143002/diff/20001/webrtc/video_engine/vie_encoder.cc#newcode690 webrtc/video_engine/vie_encoder.cc:690: LOG(LS_INFO) << "Video suspend state changed " << video_is_suspended ...
5 years, 2 months ago (2015-10-19 11:52:59 UTC) #4
pbos-webrtc
On 2015/10/19 11:52:59, mflodman wrote: > https://codereview.webrtc.org/1412143002/diff/20001/webrtc/video_engine/vie_encoder.cc > File webrtc/video_engine/vie_encoder.cc (right): > > https://codereview.webrtc.org/1412143002/diff/20001/webrtc/video_engine/vie_encoder.cc#newcode690 > ...
5 years, 2 months ago (2015-10-19 12:02:39 UTC) #5
pbos-webrtc
(lgtm)
5 years, 2 months ago (2015-10-19 12:02:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412143002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412143002/40001
5 years, 2 months ago (2015-10-19 12:09:00 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
5 years, 2 months ago (2015-10-19 13:30:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412143002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412143002/40001
5 years, 2 months ago (2015-10-19 13:34:18 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_FAILED, no build URL) android_dbg on ...
5 years, 2 months ago (2015-10-19 13:36:03 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412143002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412143002/40001
5 years, 2 months ago (2015-10-19 14:00:50 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-19 15:12:15 UTC) #17
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 15:12:29 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0dbf0090a961c5e5fb7362937108337564b4a91f
Cr-Commit-Position: refs/heads/master@{#10324}

Powered by Google App Engine
This is Rietveld 408576698