Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: webrtc/system_wrappers/BUILD.gn

Issue 1412003007: Remove system_wrappers dep from field_trial_default and metrics_default. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/system_wrappers/BUILD.gn
diff --git a/webrtc/system_wrappers/BUILD.gn b/webrtc/system_wrappers/BUILD.gn
index c01afe6d3b1da9bb6c051147c412e34d01e09678..d90081ef1deb4639ec023a72f771b5b3846c8b86 100644
--- a/webrtc/system_wrappers/BUILD.gn
+++ b/webrtc/system_wrappers/BUILD.gn
@@ -179,10 +179,6 @@ source_set("field_trial_default") {
configs += [ "..:common_config" ]
public_configs = [ "..:common_inherited_config" ]
-
- deps = [
- ":system_wrappers",
- ]
}
source_set("metrics_default") {
@@ -192,10 +188,6 @@ source_set("metrics_default") {
configs += [ "..:common_config" ]
public_configs = [ "..:common_inherited_config" ]
-
- deps = [
- ":system_wrappers",
- ]
}
source_set("system_wrappers_default") {
@@ -203,6 +195,7 @@ source_set("system_wrappers_default") {
public_configs = [ "..:common_inherited_config" ]
deps = [
+ ":system_wrappers_default",
guoweis_webrtc 2015/10/27 23:08:07 IS this right? Shouldn't this be system_wrappers?
Sergey Ulanov 2015/10/28 00:18:42 Yes, thanks for catching it
":field_trial_default",
":metrics_default",
]
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698