Issue 1411813004: Fix thread safety in VcmCapturer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1411813004: Fix thread safety in VcmCapturer. (Closed)

Created:
5 years, 2 months ago by pbos-webrtc

Modified:
5 years, 2 months ago

Reviewers:
mflodman

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

Fix thread safety in VcmCapturer. Makes VcmCapturer::Stop() blocking so that no frames can be in delivery while the camera has stopped. BUG= R=mflodman@webrtc.org Committed: https://crrev.com/1e737c6f2cf835a5b38dab0fc989ab52a749c87a Cr-Commit-Position: refs/heads/master@{#10385}

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -7 lines)			Patch
	M	webrtc/test/vcm_capturer.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
	M	webrtc/test/vcm_capturer.cc	View		2 chunks	+13 lines, -6 lines	0 comments	Download

Total messages: 4 (0 generated)

pbos-webrtc

Committed patchset #1 (id:1) manually as 1e737c6f2cf835a5b38dab0fc989ab52a749c87a (presubmit successful).

5 years, 2 months ago (2015-10-23 12:46:11 UTC) #3

commit-bot: I haz the power

5 years, 2 months ago (2015-10-23 12:46:16 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/1e737c6f2cf835a5b38dab0fc989ab52a749c87a
Cr-Commit-Position: refs/heads/master@{#10385}