Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 1411573007: Removed vie_defines.h (Closed)

Created:
5 years, 1 month ago by mflodman
Modified:
5 years, 1 month ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, mflodman, the sun, perkj_webrtc, andresp
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removed vie_defines.h The defines still in use was only used in single files, so they were moved to these specific cc-files. Committed: https://crrev.com/c4a1c370aa7e4ec467ff16162ca0eef0cfaf53b0 Cr-Commit-Position: refs/heads/master@{#10539}

Patch Set 1 #

Total comments: 10

Patch Set 2 : staticz #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -145 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_packet_history_unittest.cc View 1 2 4 chunks +3 lines, -3 lines 0 comments Download
M webrtc/test/channel_transport/channel_transport.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/video/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/video_capture_input.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/video_send_stream.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M webrtc/video/webrtc_video.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video_engine/vie_channel.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video_engine/vie_channel.cc View 1 2 5 chunks +9 lines, -6 lines 0 comments Download
D webrtc/video_engine/vie_defines.h View 1 chunk +0 lines, -120 lines 0 comments Download
M webrtc/video_engine/vie_encoder.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video_engine/vie_encoder.cc View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
M webrtc/video_engine/vie_receiver.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mflodman
pbos, Please take a look at this CL removing vie_defines.h.
5 years, 1 month ago (2015-10-28 19:50:52 UTC) #2
pbos-webrtc
awesome, I thought I had a CL for doing this, either way it gets done, ...
5 years, 1 month ago (2015-10-29 15:39:41 UTC) #3
mflodman
https://codereview.webrtc.org/1411573007/diff/1/webrtc/modules/rtp_rtcp/source/rtp_packet_history_unittest.cc File webrtc/modules/rtp_rtcp/source/rtp_packet_history_unittest.cc (right): https://codereview.webrtc.org/1411573007/diff/1/webrtc/modules/rtp_rtcp/source/rtp_packet_history_unittest.cc#newcode270 webrtc/modules/rtp_rtcp/source/rtp_packet_history_unittest.cc:270: const int kSendSidePacketHistorySize = 600; On 2015/10/29 15:39:40, pbos-webrtc ...
5 years, 1 month ago (2015-11-06 11:38:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411573007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411573007/40001
5 years, 1 month ago (2015-11-06 11:44:00 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-06 12:33:54 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 12:34:00 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c4a1c370aa7e4ec467ff16162ca0eef0cfaf53b0
Cr-Commit-Position: refs/heads/master@{#10539}

Powered by Google App Engine
This is Rietveld 408576698