Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1411253002: Remove old VideoFrame::Reset. (Closed)

Created:
5 years, 2 months ago by pbos-webrtc
Modified:
5 years, 2 months ago
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove old VideoFrame::Reset. Hopefully all external implementations are updated, I could build Chromium locally with this patch. This Reset implementation causes (for some mysterious reason) -WError=overloaded-virtual failures when trying to build libjingle APKs. R=guoweis@webrtc.org, magjed@webrtc.org, pthatcher@webrtc.org BUG=webrtc:2365 Committed: https://crrev.com/b64a32bf25367d3a32a081680cb9f1972e06759a Cr-Commit-Position: refs/heads/master@{#10352}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M talk/media/base/videoframe.h View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
pbos-webrtc
PTAL, magjed@. pthatcher@ for rubberstamp :)
5 years, 2 months ago (2015-10-19 13:47:01 UTC) #1
magjed_webrtc
lgtm
5 years, 2 months ago (2015-10-20 15:44:21 UTC) #2
pthatcher1
lgtm Adding guoweis@ since he wrote the TODO to remove it.
5 years, 2 months ago (2015-10-20 20:02:21 UTC) #4
guoweis_webrtc
On 2015/10/20 20:02:21, pthatcher1 wrote: > lgtm > > Adding guoweis@ since he wrote the ...
5 years, 2 months ago (2015-10-20 20:21:37 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b64a32bf25367d3a32a081680cb9f1972e06759a Cr-Commit-Position: refs/heads/master@{#10352}
5 years, 2 months ago (2015-10-21 09:54:19 UTC) #6
pbos-webrtc
5 years, 2 months ago (2015-10-21 09:54:19 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b64a32bf25367d3a32a081680cb9f1972e06759a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698