Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1008)

Unified Diff: webrtc/modules/audio_processing/echo_cancellation_impl.h

Issue 1410833002: Lock scheme #4: Introduced the render sample queue for the aec and aecm (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@aec_error_report_CL
Patch Set: Merge from other CLs in the list Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_processing/echo_cancellation_impl.h
diff --git a/webrtc/modules/audio_processing/echo_cancellation_impl.h b/webrtc/modules/audio_processing/echo_cancellation_impl.h
index 070dcabc5d6df0447dcaaa65dfe5c205031993ac..1389399da3a457adba868e84e0eb4651af5c1dd7 100644
--- a/webrtc/modules/audio_processing/echo_cancellation_impl.h
+++ b/webrtc/modules/audio_processing/echo_cancellation_impl.h
@@ -11,11 +11,31 @@
#ifndef WEBRTC_MODULES_AUDIO_PROCESSING_ECHO_CANCELLATION_IMPL_H_
#define WEBRTC_MODULES_AUDIO_PROCESSING_ECHO_CANCELLATION_IMPL_H_
+#include "webrtc/base/scoped_ptr.h"
+#include "webrtc/common_audio/swap_queue.h"
#include "webrtc/modules/audio_processing/include/audio_processing.h"
#include "webrtc/modules/audio_processing/processing_component.h"
namespace webrtc {
+namespace {
hlundin-webrtc 2015/11/05 12:57:02 "Do not use unnamed namespaces in .h files." https
peah-webrtc 2015/11/06 06:55:04 Done.
+// Functor to use when supplying a verifier function for the queue item
+// verifcation.
+class AecRenderQueueItemVerifier {
+ public:
+ explicit AecRenderQueueItemVerifier(size_t minimum_capacity)
+ : minimum_capacity_(minimum_capacity) {}
+
+ bool operator()(const std::vector<float>& v) const {
+ return v.capacity() >= minimum_capacity_;
+ }
+
+ private:
+ size_t minimum_capacity_;
+};
+
+} // namespace anonymous
+
class AudioBuffer;
class CriticalSectionWrapper;
@@ -42,7 +62,16 @@ class EchoCancellationImpl : public EchoCancellation,
bool is_delay_agnostic_enabled() const;
bool is_extended_filter_enabled() const;
+ // Reads render side data that has been queued on the render call.
+ void ReadQueuedRenderData();
+
private:
+ static const size_t kAllowedValuesOfSamplesPerFrame1 = 80;
+ static const size_t kAllowedValuesOfSamplesPerFrame2 = 160;
+ // TODO(peah): Decrease this once we properly handle hugely unbalanced
+ // reverse and forward call numbers.
+ static const size_t kMaxNumFramesToBuffer = 100;
+
// EchoCancellation implementation.
int Enable(bool enable) override;
int enable_drift_compensation(bool enable) override;
@@ -68,6 +97,8 @@ class EchoCancellationImpl : public EchoCancellation,
int num_handles_required() const override;
int GetHandleError(void* handle) const override;
+ void AllocateRenderQueue();
+
const AudioProcessing* apm_;
CriticalSectionWrapper* crit_;
bool drift_compensation_enabled_;
@@ -79,6 +110,12 @@ class EchoCancellationImpl : public EchoCancellation,
bool delay_logging_enabled_;
bool extended_filter_enabled_;
bool delay_agnostic_enabled_;
+
+ size_t render_queue_element_max_size_;
+ std::vector<float> render_queue_buffer_;
+ std::vector<float> capture_queue_buffer_;
+ rtc::scoped_ptr<SwapQueue<std::vector<float>, AecRenderQueueItemVerifier>>
+ render_signal_queue_;
};
} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698