Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1410643005: Remove dummyinstantiation.cc. (Closed)

Created:
5 years, 2 months ago by pbos-webrtc
Modified:
5 years, 2 months ago
Reviewers:
the sun
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove dummyinstantiation.cc. Prevented Android libjingle APK building since EnsureAPIMatch is defined but not used. BUG=webrtc:2365 R=solenberg@webrtc.org Committed: https://crrev.com/f56eca031cf64ecaa3a0ae3f77f8a2e14b09092e Cr-Commit-Position: refs/heads/master@{#10323}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -33 lines) Patch
M talk/libjingle_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D talk/media/webrtc/dummyinstantiation.cc View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
the sun
lgtm
5 years, 2 months ago (2015-10-19 12:46:44 UTC) #1
pbos-webrtc
Committed patchset #1 (id:1) manually as f56eca031cf64ecaa3a0ae3f77f8a2e14b09092e (presubmit successful).
5 years, 2 months ago (2015-10-19 12:47:25 UTC) #2
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 12:47:28 UTC) #3
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f56eca031cf64ecaa3a0ae3f77f8a2e14b09092e
Cr-Commit-Position: refs/heads/master@{#10323}

Powered by Google App Engine
This is Rietveld 408576698