Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1410543012: [Android WebView] Implement support for persistent notifications.

Created:
5 years, 1 month ago by timvolodine
Modified:
3 years, 2 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android WebView] Implement support for persistent notifications. This patch implements the necessary classes for the plumbing of notifications in android_webview. It provides a notifications service which dispatches the relevant notification calls from content all the way to java (but not yet to android). In particular this patch implements: - lightweight AwNotification representation for webview, - AwNotificationUIManager (native + java), - JNI related bits for AwNotificicationUIManager (native+java), - AwPlatformNotificationService, TODO: (unit) tests BUG=551446

Patch Set 1 #

Total comments: 28

Patch Set 2 : rebase #

Patch Set 3 : address comments #

Messages

Total messages: 6 (2 generated)
timvolodine
initial patch for enabling notification support in webview, ptal. torne@: in particular android_webview and structure. ...
5 years, 1 month ago (2015-11-04 17:19:10 UTC) #2
Peter Beverloo
Hi Tim, Thank you for the patch! :) It's super cool to see this coming ...
5 years, 1 month ago (2015-11-06 12:57:44 UTC) #3
timvolodine
Hi Peter, thanks for your comments! I've addressed most of them see replies below. I ...
5 years ago (2015-12-04 13:39:57 UTC) #4
mfarrar03
3 years, 2 months ago (2017-09-26 04:15:55 UTC) #6

          

Powered by Google App Engine
This is Rietveld 408576698