Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1410533004: Round Rate computations from RateTracker. (Closed)

Created:
5 years, 1 month ago by tpsiaki
Modified:
5 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, andresp, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Round Rate computations from RateTracker. BUG=534221 R=asapersson@webrtc.org, pbos@webrtc.org, pthatcher@webrtc.org Committed: https://crrev.com/ad13d2f8178af5efbe516184995af02a171ec66a Cr-Commit-Position: refs/heads/master@{#10592}

Patch Set 1 #

Patch Set 2 : Add cmath include. #

Patch Set 3 : Round rate tracker partial buckets #

Patch Set 4 : Correct first-bucket rounding. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M webrtc/base/ratetracker.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M webrtc/p2p/base/port.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/video/receive_statistics_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/video/send_statistics_proxy.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
tpsiaki1
5 years, 1 month ago (2015-11-05 18:14:18 UTC) #4
tpsiaki1
I've verified that this does indeed fix the 3.3% statistics problem that was showing up ...
5 years, 1 month ago (2015-11-05 23:12:31 UTC) #5
pbos-webrtc
I think asapersson@ is better for this than me (+R).
5 years, 1 month ago (2015-11-10 14:35:10 UTC) #7
pbos-webrtc
lgtm, but I'd like her to stamp as well
5 years, 1 month ago (2015-11-10 14:36:14 UTC) #8
åsapersson
lgtm
5 years, 1 month ago (2015-11-10 15:54:21 UTC) #9
pthatcher1
lgtm
5 years, 1 month ago (2015-11-11 00:34:15 UTC) #10
tpsiaki
Committed patchset #4 (id:60001) manually as ad13d2f8178af5efbe516184995af02a171ec66a (presubmit successful).
5 years, 1 month ago (2015-11-11 00:35:03 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-11 00:35:09 UTC) #12
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/ad13d2f8178af5efbe516184995af02a171ec66a
Cr-Commit-Position: refs/heads/master@{#10592}

Powered by Google App Engine
This is Rietveld 408576698